[Xen-devel] [xen-4.10-testing test] 119859: tolerable FAIL - PUSHED

2018-02-23 Thread osstest service owner
flight 119859 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/119859/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 10 windows-install fail in 119777 pass in 119859 test-armhf-armhf-xl-x

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 12:57 AM, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to be filled. This is not needed for the fuzzer to get working correctly. The maximum size for the input s

[Xen-devel] [PATCH v2] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-23 Thread Jan Beulich
... for non-existent MSRs: wrmsr_hypervisor_regs()'s comment clearly says that the function returns 0 for unrecognized MSRs, so {svm,vmx}_msr_write_intercept() should not convert this into success. We don't want to unconditionally fail the access though, as we can't be certain the list of handled M

Re: [Xen-devel] [RFC Patch v4 4/8] hvmloader: boot cpu through broadcast

2018-02-23 Thread Jan Beulich
>>> On 22.02.18 at 19:44, wrote: > On Wed, Dec 06, 2017 at 03:50:10PM +0800, Chao Gao wrote: >> +"mov $lock,%edx\n" > > Not really an expert in x86 asm -- shouldn't this be lea instead? No, when MOV can be used it's preferable as having a 1 byte shorter encoding. There are

Re: [Xen-devel] [RFC Patch v4 8/8] x86/hvm: bump the maximum number of vcpus to 512

2018-02-23 Thread Jan Beulich
>>> On 22.02.18 at 19:46, wrote: > On Wed, Dec 06, 2017 at 03:50:14PM +0800, Chao Gao wrote: >> --- a/xen/include/public/hvm/hvm_info_table.h >> +++ b/xen/include/public/hvm/hvm_info_table.h >> @@ -32,7 +32,7 @@ >> #define HVM_INFO_PADDR ((HVM_INFO_PFN << 12) + HVM_INFO_OFFSET) >> >> /*

Re: [Xen-devel] [PATCH] README: require Python 2.6 or newer

2018-02-23 Thread Jan Beulich
>>> On 22.02.18 at 20:34, wrote: > Increase the minimum required Python to 2.6 or newer. > > Signed-off-by: Doug Goldstein That's the easy half. Tool stack configure scripts will also want to be adjusted (see the thread rooted at https://lists.xenproject.org/archives/html/xen-devel/2017-09/msg0

Re: [Xen-devel] [Minios-devel] Excited for Xen Project in Outreachy

2018-02-23 Thread Lars Kurth
Hi Kanika, > On 22 Feb 2018, at 20:34, KANIKA SAINI wrote: > > > Issue suggested by Simon > In Unikraft - whenever compiler flags are changed due to an addition of a > library or something else according to the build rules, the make command > doesn't force recompilation of those files affecte

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 06:23, wrote: >> From: Paul Durrant [mailto:paul.durr...@citrix.com] >> Sent: Tuesday, February 13, 2018 5:25 PM >> > From: Tian, Kevin [mailto:kevin.t...@intel.com] >> > Sent: 13 February 2018 06:52 >> > > From: Paul Durrant >> > > Sent: Monday, February 12, 2018 6:47 PM >> >

Re: [Xen-devel] [PATCH 5/5] xen/libxc: suppress direct access to Credit1's migration delay

2018-02-23 Thread Jan Beulich
>>> On 22.02.18 at 17:55, wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -351,8 +351,6 @@ struct xen_sysctl_pm_op { > uint32_tset_sched_opt_smt; > uint32_tget_max_cstate; > uint32_t

[Xen-devel] [xtf test] 119881: all pass - PUSHED

2018-02-23 Thread osstest service owner
flight 119881 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/119881/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 3a83f436494b9cc46582c94d69348401466eebb0 baseline version: xtf d6bd213188c6e4b2f7c6ff

Re: [Xen-devel] [PATCH 7/7] x86: add iommu_ops to map and unmap pages, and also to flush the IOTLB

2018-02-23 Thread Paul Durrant
> -Original Message- > From: Tian, Kevin [mailto:kevin.t...@intel.com] > Sent: 23 February 2018 05:36 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Stefano Stabellini ; Wei Liu > ; George Dunlap ; > Andrew Cooper ; Ian Jackson > ; Tim (Xen.org) ; Jan Beulich > > Subject: RE: [X

Re: [Xen-devel] [PATCH 5/7] public / x86: introduce __HYPERCALL_iommu_op

2018-02-23 Thread Paul Durrant
> -Original Message- > From: Tian, Kevin [mailto:kevin.t...@intel.com] > Sent: 23 February 2018 05:17 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Stefano Stabellini ; Wei Liu > ; George Dunlap ; > Andrew Cooper ; Ian Jackson > ; Tim (Xen.org) ; Jan Beulich > ; Daniel De Graaf

Re: [Xen-devel] [PATCH 1/2] x86/svm: add support for pause filtering threshold

2018-02-23 Thread Jan Beulich
>>> On 21.02.18 at 01:12, wrote: > Add support for enabling the pause filtering threshold feature. This > causes the pause filtering count to reset if there's pause filtering > threshold cycles or greater between pauses. See AMD APM Vol 2 Section > 15.14.4 for more details. FTR I'm going to com

[Xen-devel] [PATCH v3] hvm/svm: Implement CPUID events

2018-02-23 Thread Alexandru Isaila
At this moment the CPUID events for the AMD architecture are not forwarded to the monitor layer. This patch adds the CPUID event to the common capabilities and then forwards the event to the monitor layer. --- Changes since V2: - Pass the inst_len to svm_vmexit_do_cpuid() Signed-off-

Re: [Xen-devel] [PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed

2018-02-23 Thread Jan Beulich
>>> On 22.02.18 at 12:12, wrote: > When files are added or removed /dev/null is used as a place > holder name in the patch for the absent file. Don't try and > find a MAINTAINER for this place holder, it only ever flags > and then spams THE REST, behaviour for a real filename is > unchanged. > >

Re: [Xen-devel] [PATCH 5/5] xen/libxc: suppress direct access to Credit1's migration delay

2018-02-23 Thread Dario Faggioli
On Fri, 2018-02-23 at 02:11 -0700, Jan Beulich wrote: > > > > On 22.02.18 at 17:55, wrote: > > > > --- a/xen/include/public/sysctl.h > > +++ b/xen/include/public/sysctl.h > > @@ -351,8 +351,6 @@ struct xen_sysctl_pm_op { > > uint32_tset_sched_opt_smt; > > uin

Re: [Xen-devel] [PATCH v2] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-23 Thread Andrew Cooper
On 23/02/2018 08:36, Jan Beulich wrote: > ... for non-existent MSRs: wrmsr_hypervisor_regs()'s comment clearly > says that the function returns 0 for unrecognized MSRs, so > {svm,vmx}_msr_write_intercept() should not convert this into success. We > don't want to unconditionally fail the access thou

Re: [Xen-devel] [PATCH v2] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 11:07, wrote: > On 23/02/2018 08:36, Jan Beulich wrote: >> ... for non-existent MSRs: wrmsr_hypervisor_regs()'s comment clearly >> says that the function returns 0 for unrecognized MSRs, so >> {svm,vmx}_msr_write_intercept() should not convert this into success. We >> don't want

Re: [Xen-devel] [PATCH v3 2/2] vmx/hap: optimize CR4 trapping

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 04:56:38AM +, Tian, Kevin wrote: > > From: Roger Pau Monne [mailto:roger@citrix.com] > > Sent: Tuesday, February 20, 2018 4:57 PM > > > > There a bunch of bits in CR4 that should be allowed to be set directly > > by the guest without requiring Xen intervention, curr

[Xen-devel] [PATCH] x86: add .size directive to indirect thunk generation macro

2018-02-23 Thread Jan Beulich
Not adding .type, as these are neither functions nor objects. Signed-off-by: Jan Beulich --- a/xen/arch/x86/indirect-thunk.S +++ b/xen/arch/x86/indirect-thunk.S @@ -41,6 +41,7 @@ ENTRY(__x86_indirect_thunk_\reg) ALTERNATIVE_2 __stringify(IND_THUNK_RETPOLINE \reg), \

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread George Dunlap
Paul, thanks for reporting this! A couple of comments... On 02/22/2018 11:57 PM, Paul Semel wrote: > The minimum size for the input size was set to DATA_OFFSET + 1 which was > meaning > that we were requesting at least one character of the data array to be filled. > This is not needed for the fu

Re: [Xen-devel] [PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed

2018-02-23 Thread Ian Jackson
Alan Robinson writes ("[PATCH v2 ] get_maintainers.pl: Avoid THE_REST when files are added or removed"): > When files are added or removed /dev/null is used as a place > holder name in the patch for the absent file. Don't try and > find a MAINTAINER for this place holder, it only ever flags > and

Re: [Xen-devel] [PATCH] x86: add .size directive to indirect thunk generation macro

2018-02-23 Thread Andrew Cooper
On 23/02/18 10:24, Jan Beulich wrote: > Not adding .type, as these are neither functions nor objects. > > Signed-off-by: Jan Beulich @function is for executable code in general.  It is not restricted to C's idea of function. This is how GCC writes a repoline thunk:     .section    .text.__x86_i

Re: [Xen-devel] [PATCH] x86: add .size directive to indirect thunk generation macro

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 12:09, wrote: > On 23/02/18 10:24, Jan Beulich wrote: >> Not adding .type, as these are neither functions nor objects. >> >> Signed-off-by: Jan Beulich > > @function is for executable code in general. It is not restricted to > C's idea of function. Oh, indeed, I forgot that

Re: [Xen-devel] [RFC PATCH 35/49] ARM: new VGIC: Add TARGET registers handlers

2018-02-23 Thread Andre Przywara
Hi, On 19/02/18 11:53, Julien Grall wrote: > Hi Andre, > > On 09/02/18 14:39, Andre Przywara wrote: >> The target register handlers are v2 emulation specific, so their >> implementation lives entirely in vgic-mmio-v2.c. >> We copy the old VGIC behaviour of assigning an IRQ to the first VCPU >> se

Re: [Xen-devel] [RFC PATCH 37/49] ARM: new VGIC: Add SGIPENDR register handlers

2018-02-23 Thread Andre Przywara
Hi, On 19/02/18 12:02, Julien Grall wrote: > Hi, > > On 09/02/18 14:39, Andre Przywara wrote: >> As this register is v2 specific, its implementation lives entirely >> in vgic-mmio-v2.c. >> This register allows setting the source mask of an IPI. >> >> This is based on Linux commit ed40213ef9b0, wr

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

2018-02-23 Thread Andrew Cooper
On 22/02/18 13:39, Jan Beulich wrote: On 22.02.18 at 13:39, wrote: >> On 02/22/2018 12:22 PM, Jan Beulich wrote: >> On 22.02.18 at 12:41, wrote: On 22/02/18 11:33, Jan Beulich wrote: On 22.02.18 at 11:51, wrote: >> as-insn-check mutates the passed-in flags. Rename it

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 11:40:34AM +, Andrew Cooper wrote: > On 22/02/18 13:39, Jan Beulich wrote: > On 22.02.18 at 13:39, wrote: > >> On 02/22/2018 12:22 PM, Jan Beulich wrote: > >> On 22.02.18 at 12:41, wrote: > On 22/02/18 11:33, Jan Beulich wrote: > On 22.02.18 at 1

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

2018-02-23 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] build: Rename as-insn-check to as-insn-add"): > Ok - how do we unblock this? > > There appears to be agreement that as-insn-check isn't a great name, and > my proposed as-insn-add isn't much better. > > The base runes of as-insn and cc-option are compatible.  Th

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 12:40, wrote: > On 22/02/18 13:39, Jan Beulich wrote: > On 22.02.18 at 13:39, wrote: >>> On 02/22/2018 12:22 PM, Jan Beulich wrote: >>> On 22.02.18 at 12:41, wrote: > On 22/02/18 11:33, Jan Beulich wrote: > On 22.02.18 at 11:51, wrote: >>> as-insn-chec

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Paul Semel
On 02/23/2018 11:44 AM, George Dunlap wrote: Paul, thanks for reporting this! A couple of comments... On 02/22/2018 11:57 PM, Paul Semel wrote: The minimum size for the input size was set to DATA_OFFSET + 1 which was meaning that we were requesting at least one character of the data array to

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

2018-02-23 Thread Andrew Cooper
On 23/02/18 11:58, Jan Beulich wrote: On 23.02.18 at 12:40, wrote: >> On 22/02/18 13:39, Jan Beulich wrote: >> On 22.02.18 at 13:39, wrote: On 02/22/2018 12:22 PM, Jan Beulich wrote: On 22.02.18 at 12:41, wrote: >> On 22/02/18 11:33, Jan Beulich wrote: >> On 22

[Xen-devel] [xen-unstable-smoke test] 119959: tolerable all pass - PUSHED

2018-02-23 Thread osstest service owner
flight 119959 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/119959/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH RFC] x86: slightly reduce RSB overwrite overhead

2018-02-23 Thread Jan Beulich
>>> On 21.02.18 at 12:09, wrote: > Avoiding the PAUSE/LFENCE pair on the first of the two unrolled > iterations not only reduces code size, but also improves performance > according to my (limited) measurements (by 15-20 cycles on my Westmere; > granted I can't really explain why that is). Now tha

[Xen-devel] [PATCH v2] build: Rename as-insn-check to as-option-add

2018-02-23 Thread Andrew Cooper
as-insn-check mutates the passed-in flags. Rename it to as-option-add, in line with cc-option-add, and update all callers. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Rog

Re: [Xen-devel] [PATCH v2] build: Rename as-insn-check to as-option-add

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 01:10:34PM +, Andrew Cooper wrote: > as-insn-check mutates the passed-in flags. Rename it to as-option-add, in > line with cc-option-add, and update all callers. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger. _

Re: [Xen-devel] [PATCH v2] build: Rename as-insn-check to as-option-add

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 14:10, wrote: > as-insn-check mutates the passed-in flags. Rename it to as-option-add, in > line with cc-option-add, and update all callers. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-

[Xen-devel] [PATCH RFC 1/3] x86/vpt: execute callbacks for masked interrupts

2018-02-23 Thread Roger Pau Monne
Execute periodic_time callbacks even if the interrupt is not actually injected because the IRQ is masked. Current callbacks from emulated timer devices only update emulated registers, which from my reading of the specs should happen regardless of whether the interrupt has been injected or not. Si

[Xen-devel] [PATCH RFC 0/3] hpet: add support for level triggered interrupts

2018-02-23 Thread Roger Pau Monne
Hello, This series add support for level triggered HPET interrupts, which are mandatory according to the spec. First patch is a change for vpt in order to execute the timer callbacks even if the interrupt is not injected because the IRQ is masked. Second patch implements support for level trigger

[Xen-devel] [PATCH RFC 2/3] vhpet: add support for level triggered interrupts

2018-02-23 Thread Roger Pau Monne
Level triggered interrupts are not an optional feature of HPET, and must be implemented in order to comply with the HPET specification. Implement them by adding a callback to the timer which sets the interrupt bit in the general interrupt status register. Further interrupts (in case of periodic mo

[Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-02-23 Thread Roger Pau Monne
Add a basic HPET functionality test, note that this test requires the HPET to support level triggered interrupts. Further improvements should add support for interrupt delivery, and testing all the available timers. Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper --- arch/x86/include/arch

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Don't shadow the domain parameter in hvm_save_cpu_msrs()

2018-02-23 Thread Jan Beulich
>>> On 20.02.18 at 12:58, wrote: > c/s d2f86bf604 which introduced "struct hvm_save_descriptor *d" accidentally > ended up shadowing the "struct domain *d" function parameter. Rename the > former to desc. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___

Re: [Xen-devel] [PATCH 2/5] x86/pv: Avoid leaking other guests' MSR_TSC_AUX values into PV context

2018-02-23 Thread Jan Beulich
>>> On 20.02.18 at 12:58, wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -1533,9 +1533,9 @@ void paravirt_ctxt_switch_to(struct vcpu *v) > if ( unlikely(v->arch.debugreg[7] & DR7_ACTIVE_MASK) ) > activate_debugregs(v); > > -if ( (v->domain->arch.tsc_mod

Re: [Xen-devel] [PATCH 3/7] x86/alt: Clean up the assembly used to generate alternatives

2018-02-23 Thread Andrew Cooper
On 13/02/18 14:37, Jan Beulich wrote: > >>> On 12.02.18 at 12:23, wrote: >> --- a/xen/include/asm-x86/alternative-asm.h >> +++ b/xen/include/asm-x86/alternative-asm.h >> @@ -9,60 +9,67 @@ >> * enough information for the alternatives patching code to patch an >> * instruction. See apply_altern

[Xen-devel] [PATCH v6] x86/clang: allow integrated assembler usage

2018-02-23 Thread Roger Pau Monne
If the required features are present. Modify as-option-add to add an option in case the test fails, and use it to detect whether the required clang integrated assembler features are present. This patch has been tested with clang 3.5, clang 6, gcc 6.4.0 without retpoline support and gcc 7.3.1 with

Re: [Xen-devel] [PATCH 2/5] x86/pv: Avoid leaking other guests' MSR_TSC_AUX values into PV context

2018-02-23 Thread Andrew Cooper
On 23/02/18 14:04, Jan Beulich wrote: On 20.02.18 at 12:58, wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -1533,9 +1533,9 @@ void paravirt_ctxt_switch_to(struct vcpu *v) >> if ( unlikely(v->arch.debugreg[7] & DR7_ACTIVE_MASK) ) >> activate_debugregs(

Re: [Xen-devel] [PATCH 3/5] tools: libxl/xl: allow to get/set Credit1's vcpu_migration_delay

2018-02-23 Thread Dario Faggioli
On Thu, 2018-02-22 at 17:55 +0100, Dario Faggioli wrote: > --- a/tools/libxl/libxl_sched.c > +++ b/tools/libxl/libxl_sched.c > @@ -505,6 +507,9 @@ int main_sched_credit(int argc, char **argv) > ratelimit = strtol(optarg, NULL, 10); > opt_r = true; > break; > +case 'm'

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 02:53 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> static int __init xen_drv_init(void) >>> { >>> +/* At the moment we only support case with XEN_PAGE_SIZE == >>> PAGE_SIZE *

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 01:37 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 12:23 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> +static struct xenbus_driver xen_driver = { >>> +.ids = xen_drv_ids, >>> +.probe = xen_drv_probe, >>> +.remove = xen_drv_

Re: [Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-23 Thread Jan Beulich
>>> On 20.02.18 at 12:58, wrote: > Having pv_soft_rdtsc() emulate all parts of an rdtscp is awkward, and gets in > the way of some intended cleanup. > > * Drop the rdtscp parameter and always make the caller responsible for ecx >updates when appropriate. > * Switch the function from being v

Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-23 Thread Jan Beulich
>>> On 20.02.18 at 12:58, wrote: > The handling of RDTSCP for PV guests has been broken (AFAICT forever). > > To start with, RDTSCP is hidden from PV guests so the MSR_TSC_AUX path should > be unreachable. However, this appears to be a "feature" of TSC_MODE_PVRDTSCP, > and the emulator doesn't p

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 02:00 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 01:50 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> + >>> +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) >>> +{ >>> +struct xen_drm_front_evtchnl *evtchnl = dev_i

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-23 Thread Oleksandr Andrushchenko
On 02/23/2018 04:36 PM, Boris Ostrovsky wrote: On 02/23/2018 02:53 AM, Oleksandr Andrushchenko wrote: On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: static int __init xen_drv_init(void) { +/* At the moment we only support case

Re: [Xen-devel] [RFC PATCH 33/49] ARM: new VGIC: Add PRIORITY registers handlers

2018-02-23 Thread Andre Przywara
Hi, On 16/02/18 17:38, Julien Grall wrote: > Hi Andre, > > On 09/02/18 14:39, Andre Przywara wrote: >> The priority register handlers are shared between the v2 and v3 >> emulation, >> so their implementation goes into vgic-mmio.c, to be easily referenced >> from the v3 emulation as well later. >>

Re: [Xen-devel] [PATCH v3] hvm/svm: Implement CPUID events

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 04:46 AM, Alexandru Isaila wrote: > At this moment the CPUID events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the CPUID event to the common capabilities and then > forwards the event to the monitor layer. > > --- > Changes since V2: >

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-23 Thread Oleksandr Andrushchenko
On 02/23/2018 04:44 PM, Boris Ostrovsky wrote: On 02/23/2018 02:00 AM, Oleksandr Andrushchenko wrote: On 02/23/2018 01:50 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: + +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) +{ +struct xen_drm

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-23 Thread Oleksandr Andrushchenko
On 02/23/2018 04:39 PM, Boris Ostrovsky wrote: On 02/23/2018 01:37 AM, Oleksandr Andrushchenko wrote: On 02/23/2018 12:23 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: +static struct xenbus_driver xen_driver = { +.ids = xen_drv_ids, +.probe = xen_drv

Re: [Xen-devel] [PATCH v2 5/5] x86: Rework MSR_TSC_AUX handling from scratch.

2018-02-23 Thread Jan Beulich
>>> On 21.02.18 at 12:36, wrote: > There are many problems with MSR_TSC_AUX handling. > > To begin with, the RDPID instruction reads MSR_TSC_AUX, but it is only the > RDTSCP feature which enumerates the MSR. Therefore, RDPID functionally > depends on RDTSCP. Are you sure this isn't a documentat

Re: [Xen-devel] [PATCH 2/5] x86/pv: Avoid leaking other guests' MSR_TSC_AUX values into PV context

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 15:22, wrote: > On 23/02/18 14:04, Jan Beulich wrote: > On 20.02.18 at 12:58, wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -1533,9 +1533,9 @@ void paravirt_ctxt_switch_to(struct vcpu *v) >>> if ( unlikely(v->arch.debugreg[7] & DR7_ACTIV

Re: [Xen-devel] [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver

2018-02-23 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +struct drm_driver xen_drm_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | > + DRIVER_PRIME | DRIVER_ATOMIC, > + .lastclose = lastclose, > + .gem_free

Re: [Xen-devel] [PATCH 3/7] x86/alt: Clean up the assembly used to generate alternatives

2018-02-23 Thread Jan Beulich
>>> On 23.02.18 at 15:03, wrote: > On 13/02/18 14:37, Jan Beulich wrote: >> >>> On 12.02.18 at 12:23, wrote: >>> --- a/xen/include/asm-x86/alternative-asm.h >>> +++ b/xen/include/asm-x86/alternative-asm.h >>> @@ -9,60 +9,67 @@ >>> * enough information for the alternatives patching code to patc

Re: [Xen-devel] [RFC PATCH 30/49] ARM: new VGIC: Add ENABLE registers handlers

2018-02-23 Thread Andre Przywara
Hi, On 16/02/18 16:57, Julien Grall wrote: > Hi Andre, > > On 09/02/18 14:39, Andre Przywara wrote: >> As the enable register handlers are shared between the v2 and v3 >> emulation, their implementation goes into vgic-mmio.c, to be easily >> referenced from the v3 emulation as well later. >> >> S

Re: [Xen-devel] [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver

2018-02-23 Thread Oleksandr Andrushchenko
On 02/23/2018 05:12 PM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: + +struct drm_driver xen_drm_driver = { + .driver_features = DRIVER_GEM | DRIVER_MODESET | +DRIVER_PRIME | DRIVER_ATOMIC, + .lastclose

Re: [Xen-devel] [PATCH] xtf: fix cdefs.h conflict with __section

2018-02-23 Thread Roger Pau Monné
On Thu, Feb 22, 2018 at 06:30:47AM -0700, Jan Beulich wrote: > >>> On 22.02.18 at 13:28, wrote: > > On 22/02/18 12:24, Jan Beulich wrote: > > On 22.02.18 at 13:03, wrote: > >>> On FreeBSD the build fails with: > >>> > >>> /root/src/xtf/include/xtf/compiler.h:13:9: error: '__section' macro >

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

2018-02-23 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > +static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size) > +{ > + struct xen_drm_front_drm_info *drm_info = dev->dev_private; > + struct xen_gem_object *xen_obj; > + int ret; > + > + size = round_up(size,

[Xen-devel] [xen-unstable test] 119879: regressions - FAIL

2018-02-23 Thread osstest service owner
flight 119879 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/119879/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl6 xen-install fail REGR. vs. 119713 Tests which did no

[Xen-devel] [PATCH RFC v3] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-02-23 Thread Alexandru Isaila
This patch adds the hvm_save_one_cpu_ctxt() function. It optimizes by only pausing the vcpu on all HVMSR_PER_VCPU save callbacks where only data for one VCPU is required. Signed-off-by: Alexandru Isaila --- Changes since V2: - Added functions for all the save_*_one cases - Added

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

2018-02-23 Thread Oleksandr Andrushchenko
On 02/23/2018 05:26 PM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: +static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size) +{ + struct xen_drm_front_drm_info *drm_info = dev->dev_private; + struct xen_gem_object *xen_obj; +

Re: [Xen-devel] [PATCH] README: require Python 2.6 or newer

2018-02-23 Thread Doug Goldstein
On 2/23/18 2:55 AM, Jan Beulich wrote: On 22.02.18 at 20:34, wrote: >> Increase the minimum required Python to 2.6 or newer. >> >> Signed-off-by: Doug Goldstein > > That's the easy half. Tool stack configure scripts will also want to > be adjusted (see the thread rooted at > https://lists.x

Re: [Xen-devel] [PATCH] README: require Python 2.6 or newer

2018-02-23 Thread George Dunlap
On 02/22/2018 07:34 PM, Doug Goldstein wrote: > Increase the minimum required Python to 2.6 or newer. > > Signed-off-by: Doug Goldstein > --- > CC: Andrew Cooper > CC: George Dunlap > CC: Ian Jackson > CC: Jan Beulich > CC: Konrad Rzeszutek Wilk > CC: Stefano Stabellini > CC: Tim Deegan >

Re: [Xen-devel] [PATCH v2 5/5] x86: Rework MSR_TSC_AUX handling from scratch.

2018-02-23 Thread Andrew Cooper
On 23/02/18 15:05, Jan Beulich wrote: On 21.02.18 at 12:36, wrote: >> There are many problems with MSR_TSC_AUX handling. >> >> To begin with, the RDPID instruction reads MSR_TSC_AUX, but it is only the >> RDTSCP feature which enumerates the MSR. Therefore, RDPID functionally >> depends on RD

Re: [Xen-devel] [PATCH v8 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2018-02-23 Thread Jan Beulich
>>> On 23.01.18 at 16:07, wrote: > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index c9b9546435..98b82680c6 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -65,6 +65,13 @@ SECTIONS > __param_start = .; > *(.data.param) > __param_

Re: [Xen-devel] [PATCH v8 03/11] x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0

2018-02-23 Thread Jan Beulich
>>> On 23.01.18 at 16:07, wrote: > So that MMCFG regions not present in the MCFG ACPI table can be added > at run time by the hardware domain. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich > --- > Cc: Jan Beulich > Cc: Andrew Cooper > --- > Changes since v7: > - Add newline i

Re: [Xen-devel] [PATCH v8 04/11] pci: split code to size BARs from pci_add_device

2018-02-23 Thread Jan Beulich
>>> On 23.01.18 at 16:07, wrote: > So that it can be called from outside in order to get the size of regular PCI > BARs. This will be required in order to map the BARs from PCI devices into PVH > Dom0 p2m. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich __

Re: [Xen-devel] [PATCH v8 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2018-02-23 Thread Julien Grall
Hi, On 23/02/18 15:55, Jan Beulich wrote: On 23.01.18 at 16:07, wrote: diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index c9b9546435..98b82680c6 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -65,6 +65,13 @@ SECTIONS __param_start = .; *(.

Re: [Xen-devel] [PATCH RFC 00/10] x86 passthrough code cleanup

2018-02-23 Thread Wei Liu
On Fri, Feb 23, 2018 at 05:12:05AM +, Tian, Kevin wrote: > > From: Wei Liu > > Sent: Thursday, February 22, 2018 5:47 AM > > > > Hi all > > > > At some point I would like to make CONFIG_HVM and CONFIG_PV work. > > The > > passthrough code is one of the road blocks for that work. > > Can you

Re: [Xen-devel] [RFC PATCH v2 2/9] hyper_dmabuf: architecture specification and reference guide

2018-02-23 Thread Roger Pau Monné
On Tue, Feb 13, 2018 at 05:50:01PM -0800, Dongwon Kim wrote: > Reference document for hyper_DMABUF driver > > Documentation/hyper-dmabuf-sharing.txt This should likely be patch 1 in order for reviewers to have the appropriate context. > > Signed-off-by: Dongwon Kim > --- > Documentation/hyper

Re: [Xen-devel] [PATCH 3/7] x86/alt: Clean up the assembly used to generate alternatives

2018-02-23 Thread Andrew Cooper
On 23/02/18 15:12, Jan Beulich wrote: On 23.02.18 at 15:03, wrote: >> On 13/02/18 14:37, Jan Beulich wrote: >>> >>> On 12.02.18 at 12:23, wrote: --- a/xen/include/asm-x86/alternative-asm.h +++ b/xen/include/asm-x86/alternative-asm.h @@ -9,60 +9,67 @@ * enough informati

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Wei Liu
On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: > The minimum size for the input size was set to DATA_OFFSET + 1 which was > meaning > that we were requesting at least one character of the data array to be filled. > This is not needed for the fuzzer to get working correctly. Sorry, I

Re: [Xen-devel] [PATCH] libxl: set channel devid when not provided by application

2018-02-23 Thread Roger Pau Monné
On Wed, Feb 07, 2018 at 08:04:10PM -0700, Jim Fehlig wrote: > Applications like libvirt may not populate a device devid field, > delegating that to libxl. If needed, the application can later > retrieve the libxl-produced devid. Indeed most devices are handled > this way in libvirt, channel devices

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread George Dunlap
On 02/23/2018 04:30 PM, Wei Liu wrote: > On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: >> The minimum size for the input size was set to DATA_OFFSET + 1 which was >> meaning >> that we were requesting at least one character of the data array to be >> filled. >> This is not needed fo

Re: [Xen-devel] [PATCH] fuzz/x86_emulate: fix bounds for input size

2018-02-23 Thread Wei Liu
On Fri, Feb 23, 2018 at 04:33:18PM +, George Dunlap wrote: > On 02/23/2018 04:30 PM, Wei Liu wrote: > > On Fri, Feb 23, 2018 at 12:57:26AM +0100, Paul Semel wrote: > >> The minimum size for the input size was set to DATA_OFFSET + 1 which was > >> meaning > >> that we were requesting at least o

[Xen-devel] [PATCH v2 2/5] xen: sched/credit1: make vcpu_migration_delay per-cpupool

2018-02-23 Thread Dario Faggioli
Right now, vCPU migration delay is controlled by the vcpu_migration_delay boot parameter. This means the same value will always be used for every instance of Credit1, in any cpupool that will be created. Also, in order to get and set such value, a special purpose libxc interface is defined, and us

[Xen-devel] [PATCH v2 1/5] xen: sched/credit: convert scheduling parameter to s_time_t when set

2018-02-23 Thread Dario Faggioli
Basically, instead of converting integers to s_time_t at usage time (hot paths), do the convertion when the values are set (cold paths). This applies to the timeslice and the ratelimit parameters of Credit1. Note that, when changing the type of the fields of struct csched_private (from unsigned t

[Xen-devel] [PATCH v2 0/5] xen/tools: sched: Credit1: improve handling of vCPU migration delay

2018-02-23 Thread Dario Faggioli
Hi, Take 2 of this series: https://lists.xenproject.org/archives/html/xen-devel/2018-02/msg02029.html The only changes are a couple of fixes for issues I found myself, in patch 3, while working on a follow-up series, and bumping SYSCTL interface version in patch 5, as suggested by Jan. Updated

[Xen-devel] [PATCH v2 5/5] xen/libxc: suppress direct access to Credit1's migration delay

2018-02-23 Thread Dario Faggioli
Removes special purpose access to Credit1 vCPU migration delay parameter. This fixes a build breakage, occuring when Xen is configured with SCHED_CREDIT=n. Signed-off-by: Dario Faggioli Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc

Re: [Xen-devel] [RFC Patch v4 4/8] hvmloader: boot cpu through broadcast

2018-02-23 Thread Roger Pau Monné
On Wed, Dec 06, 2017 at 03:50:10PM +0800, Chao Gao wrote: > Intel SDM Extended XAPIC (X2APIC) -> "Initialization by System Software" > has the following description: > > "The ACPI interfaces for the x2APIC are described in Section 5.2, “ACPI System > Description Tables,” of the Advanced Configurat

[Xen-devel] [PATCH v2 4/5] tools: xenpm: continue to support {set, get}-vcpu-migration-delay

2018-02-23 Thread Dario Faggioli
Now that it is possible to get and set the migration delay via the SCHEDOP sysctl, use that in xenpm, instead of the special purpose libxc interface (which will be removed in a following commit). The sysctl, however, requires a cpupool-id argument, for knowing on which scheduler it is operating on

[Xen-devel] [PATCH v2 3/5] tools: libxl/xl: allow to get/set Credit1's vcpu_migration_delay

2018-02-23 Thread Dario Faggioli
Make it possible to get and set a (Credit1) scheduler's vCPU migration delay via the SCHEDOP sysctl, from both libxl and xl (no change needed in libxc). Signed-off-by: Dario Faggioli --- Cc: Ian Jackson Cc: Wei Liu Cc: George Dunlap Cc: Andrew Cooper --- Changes from v1: * add missing 'break'

[Xen-devel] [PATCH v4 06/19] xen/arm64: Implement a fast path for handling SMCCC_ARCH_WORKAROUND_1

2018-02-23 Thread Julien Grall
The function SMCCC_ARCH_WORKAROUND_1 will be called by the guest for hardening the branch predictor. So we want the handling to be as fast as possible. As the mitigation is applied on every guest exit, we can check for the call before saving all the context and return very early. For now, only pr

[Xen-devel] [PATCH v4 01/19] xen/arm: psci: Rework the PSCI definitions

2018-02-23 Thread Julien Grall
Some PSCI functions are only available in the 32-bit version. After recent changes, Xen always needs to know whether the call was made using 32-bit id or 64-bit id. So we don't emulate reserved one. With the current naming scheme, it is not easy to know which call supports 32-bit and 64-bit id. So

[Xen-devel] [PATCH v4 10/19] xen/arm: smccc: Implement SMCCC v1.1 inline primitive

2018-02-23 Thread Julien Grall
One of the major improvement of SMCCC v1.1 is that it only clobbers the first 4 registers, both on 32 and 64bit. This means that it becomes very easy to provide an inline version of the SMC call primitive, and avoid performing a function call to stash the registers that woudl otherwise be clobbered

[Xen-devel] [PATCH v4 00/19] xen/arm: PSCI 1.1 and SMCCC-1.1 support and XSA-254 variant 2 update

2018-02-23 Thread Julien Grall
Hi all, Arm has recently published a SMC Calling Convention (SMCCC) specification update [1] that provides an optimised calling convention and optional, discoverable support for mitigating CVE-2017-5715 (XSA-254 variant 2). ARM Trusted Firmware (ATF) has already gained such an implementation[2].

[Xen-devel] [PATCH v4 19/19] xen/arm: vpsci: Rework the logic to start AArch32 vCPU in Thumb mode

2018-02-23 Thread Julien Grall
32-bit domain is able to select the instruction (ARM vs Thumb) to use when boot a new vCPU via CPU_ON. This is indicated via bit[0] of the entry point address (see "T32 support" in PSCI v1.1 DEN0022D). bit[0] must be cleared when setting the PC. At the moment, Xen is setting the CPSR.T but never c

[Xen-devel] [PATCH v4 02/19] xen/arm: vpsci: Add support for PSCI 1.1

2018-02-23 Thread Julien Grall
At the moment, Xen provides virtual PSCI interface compliant with 0.1 and 0.2. Since them, the specification has been updated and the latest version is 1.1 (see ARM DEN 0022D). From an implementation point of view, only PSCI_FEATURES is mandatory. The rest is optional and can be left unimplemented

[Xen-devel] [PATCH v4 05/19] xen/arm: Adapt smccc.h to be able to use it in assembly code

2018-02-23 Thread Julien Grall
Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Acked-by: Stefano Stabellini --- Changes in v4: - Add Stefano's acked-by Changes in v2: - Add Volodymyr's reviewed-by --- xen/include/asm-arm/smccc.h | 16 ++-- 1 file changed, 10 insertions(+), 6 d

[Xen-devel] [PATCH v4 18/19] xen/arm: vpsci: Introduce and use PSCI_INVALID_ADDRESS

2018-02-23 Thread Julien Grall
PSCI 1.0 added the error return PSCI_INVALID_ADDRESS. It is used to indicate the entry point address is known to be invalid. In Xen case, this error could be returned when a 64-bit vCPU is using a Thumb entry address. For PSCI 0.1 implementation, return PSCI_INVALID_PARAMETERS instead. Suggested

[Xen-devel] [PATCH v4 14/19] xen/arm: vpsci: Remove parameter 'ver' from do_common_cpu

2018-02-23 Thread Julien Grall
Currently, the behavior of do_common_cpu will slightly change depending on the PSCI version passed in parameter. Looking at the code, more the specific 0.2 behavior could move out of the function or adapted for 0.1: - x0/r0 can be updated on PSCI 0.1 because general purpose registers are u

[Xen-devel] [PATCH v4 16/19] xen/arm: psci: Prefix with static any functions not exported

2018-02-23 Thread Julien Grall
A bunch of PSCI functions are not prefixed with static despite no one is using them outside the file and the prototype is not available in psci.h. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Acked-by: Stefano Stabellini --- Changes in v4: - Add Stefano's acked-by

[Xen-devel] [PATCH v4 15/19] xen/arm: psci: Consolidate PSCI version print

2018-02-23 Thread Julien Grall
Xen is printing the same way the PSCI version for 0.1, 0.2 and later. The only different is the former is hardcoded. Furthermore PSCI is now used for other things than SMP bring up. So only print the PSCI version in psci_init. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Acked-by:

  1   2   3   >