[Xen-devel] [linux-linus test] 118598: regressions - FAIL

flight 118598 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/118598/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvhv2-amd 12 guest-start fail REGR. vs. 118324 test-amd64-amd64-xl

[Xen-devel] [PATCH] Choose retpoline only when it is safe to use

When ( ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, thunk is set to THUNK_JMP rather than THUNK_RETPOLINE. When (!ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, we should do the same. Signed-off-by: Zhenzhong Duan --- xen/arch/x86/spec_ctrl.c |4 ++-- 1 fil

Re: [Xen-devel] [PATCH] Choose retpoline only when it is safe to use

On 06/02/2018 08:43, Zhenzhong Duan wrote: > When ( ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, > thunk is set to THUNK_JMP rather than THUNK_RETPOLINE. > > When (!ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, > we should do the same. > > Signed-off-by: Zhenzhong

Re: [Xen-devel] [PATCH] Choose retpoline only when it is safe to use

在 2018/2/6 16:59, Andrew Cooper 写道: On 06/02/2018 08:43, Zhenzhong Duan wrote: When ( ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, thunk is set to THUNK_JMP rather than THUNK_RETPOLINE. When (!ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, we should do the same

Re: [Xen-devel] [PATCH] Choose retpoline only when it is safe to use

On 06/02/2018 09:13, Zhenzhong Duan wrote: > 在 2018/2/6 16:59, Andrew Cooper 写道: >> On 06/02/2018 08:43, Zhenzhong Duan wrote: >>> When ( ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, >>> thunk is set to THUNK_JMP rather than THUNK_RETPOLINE. >>> >>> When (!ibrs && thunk == THUNK_D

Re: [Xen-devel] [PATCH] x86/boot: Make alternative patching NMI-safe

>>> On 05.02.18 at 19:04, wrote: > But as you correctly pointed out, it was a very long way from being > complete. We currently have no idea whether we are in NMI context, so > arranging not to not execute an iret is hard. As long as we don't mean to patch extremely early or extremely late parts

Re: [Xen-devel] [PATCH 2/4] x86: eliminate most XPTI entry/exit code when it's not in use

>>> On 05.02.18 at 18:28, wrote: > On 30/01/18 13:51, Jan Beulich wrote: --- a/xen/arch/x86/x86_64/compat/entry.S +++ b/xen/arch/x86/x86_64/compat/entry.S @@ -189,7 +189,7 @@ ENTRY(compat_post_handle_exception) /* See lstar_enter for entry register state. */ ENTRY

[Xen-devel] [qemu-mainline test] 118600: tolerable FAIL - PUSHED

flight 118600 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/118600/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 118548 test-armhf-armhf-libvirt 14 sav

Re: [Xen-devel] [PATCH 4/4] x86: avoid double CR3 reload when switching to guest user mode

>>> On 05.02.18 at 18:37, wrote: > On 31/01/18 10:12, Jan Beulich wrote: >> --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x86/pv/domain.c @@ -220,10 +220,20 @@ int pv_domain_initialise(struct domain * return rc; } -static void _toggle_guest_pt(struct vcpu

Re: [Xen-devel] [PATCH v2] x86/boot: Make alternative patching NMI-safe

>>> On 06.02.18 at 02:07, wrote: > On 05/02/2018 19:23, Konrad Rzeszutek Wilk wrote: >> On Mon, Feb 05, 2018 at 07:10:33PM +, Andrew Cooper wrote: >>> -apply_alternatives(__alt_instructions, __alt_instructions_end); >>> +/* Send ourselves an NMI to trigger the callback. */ >>> +sel

[Xen-devel] Xen ARM community call Tuesday 13th February 5PM UTC

Hi all, I would suggest to have the next community call on Tuesday 13th February 5pm GMT. Does it sound good? Do you have any specific topic you would like to discuss? Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.o

Re: [Xen-devel] [PATCH] xen/livepatch: Drop stray tabs and fix indentation

On 02/05/2018 11:04 AM, Andrew Cooper wrote: Signed-off-by: Andrew Cooper --- CC: Konrad Rzeszutek Wilk CC: Ross Lagerwall --- xen/common/livepatch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ross Lagerwall ___

[Xen-devel] 回复: Re: [PATCH] Choose retpoline only when it is safe to use

2018年2月6日 17:20于 Andrew Cooper 写道： > > On 06/02/2018 09:13, Zhenzhong Duan wrote: > > 在 2018/2/6 16:59, Andrew Cooper 写道: > >> On 06/02/2018 08:43, Zhenzhong Duan wrote: > >>> When ( ibrs && thunk == THUNK_DEFAULT && !retpoline_safe() ) is true, > >>> thunk is set to THUNK_JMP rather than THUN

Re: [Xen-devel] [xen-unstable test] 118594: regressions - FAIL

>>> On 06.02.18 at 06:40, wrote: > flight 118594 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/118594/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-xl-qemut-ws16-amd64 7 xen-boo

[Xen-devel] [PATCH] x86/NMI: invert condition in nmi_show_execution_state()

We want to decode the symbol when _not_ in guest mode. Signed-off-by: Jan Beulich --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -632,7 +632,7 @@ static int nmi_show_execution_state(cons show_execution_state(regs); else printk(XENLOG_ERR "CPU%d @ %04x:%08lx (%pS)

Re: [Xen-devel] [PATCH] x86/NMI: invert condition in nmi_show_execution_state()

On 06/02/18 10:41, Jan Beulich wrote: > We want to decode the symbol when _not_ in guest mode. > > Signed-off-by: Jan Beulich Nice.  Figuring out why this wasn't working was on my todo list. Reviewed-by: Andrew Cooper > > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -632,7 +632

[Xen-devel] [libvirt test] 118605: tolerable all pass - PUSHED

flight 118605 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/118605/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 118557 test-armhf-armhf-libvirt-xsm 14 saveresto

Re: [Xen-devel] 回复: Re: [PATCH] Choose retpoline only when it is safe to use

On 06/02/18 10:29, zhenzhong.duan wrote: > > > 2018年2月6日 17:20于 Andrew Cooper >写道： > > > > On 06/02/2018 09:13, Zhenzhong Duan wrote: > > > 在 2018/2/6 16:59, Andrew Cooper 写道: > > >> On 06/02/2018 08:43, Zhenzhong Duan wrote: > > >>> When ( ibrs && thunk == THUNK_

Re: [Xen-devel] Xen ARM community call Tuesday 13th February 5PM UTC

Hi Julien. Thanks for looping me in. On Tue, 2018-02-06 at 10:11 +, Julien Grall wrote: > Hi all, > > I would suggest to have the next community call on Tuesday 13th > February > 5pm GMT. Does it sound good? I'm out of office from the 8th to the 16th unfortunately. > Do you have any specifi

Re: [Xen-devel] Xen ARM community call Tuesday 13th February 5PM UTC

Adding Rich > I think it would be hugely beneficial if there could be an open > repository of information that describes in clear terms what the > specific engineering items are which are needed to make Xen viable for > assessment towards safety certification. Very good idea If the

Re: [Xen-devel] [PATCH v4 2/7] xen: xsm: flask: introduce XENMAPSPACE_gmfn_share for memory sharing

Hi, On 01/30/2018 05:50 PM, Zhongze Liu wrote: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 3c328e2df5..8e385d62a8 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1251,6 +1251,7 @@ int xenmem_add_to_physmap_one( break; case XENMAPSPACE_gmfn_foreign: +

[Xen-devel] [PATCH v3] x86/boot: Make alternative patching NMI-safe

During patching, there is a very slim risk that an NMI or MCE interrupt in the middle of altering the code in the NMI/MCE paths, in which case bad things will happen. The NMI risk can be eliminated by running the patching loop in NMI context, at which point the CPU will defer further NMIs until pa

Re: [Xen-devel] Xen ARM community call Tuesday 13th February 5PM UTC

Hi Lars As we do not have Jira access, it would be better to do it on Wiki or "something else". -- Artem On 06.02.18 12:53, Lars Kurth wrote: Adding Rich I think it would be hugely beneficial if there could be an open repository of information that describes in clear terms what the specif

Re: [Xen-devel] [PATCH v4 3/7] libxl: introduce a new structure to represent static shared memory regions

Hi, On 01/30/2018 05:50 PM, Zhongze Liu wrote: Add a new structure to the IDL familiy to represent static shared memory regions s/familiy/family/ as proposed in the proposal "Allow setting up shared memory areas between VMs from xl config file" (see [1]). And deleted some trailing white spa

[Xen-devel] [seabios test] 118601: regressions - FAIL

flight 118601 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/118601/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not suc

Re: [Xen-devel] 回复: Re: [PATCH] Choose retpoline only when it is safe to use

On 2018/2/6 18:50, Andrew Cooper wrote: On 06/02/18 10:29, zhenzhong.duan wrote: 2018年2月6日 17:20于 Andrew Cooper >写道： > > On 06/02/2018 09:13, Zhenzhong Duan wrote: > > 在 2018/2/6 16:59, Andrew Cooper 写道: > >> On 06/02/2018 08:43, Zhenzhong Duan wrote: > >>> W

Re: [Xen-devel] 回复: Re: [PATCH] Choose retpoline only when it is safe to use

On 06/02/18 11:41, Zhenzhong Duan wrote: > On 2018/2/6 18:50, Andrew Cooper wrote: >> On 06/02/18 10:29, zhenzhong.duan wrote: >>> >>> >>> 2018年2月6日 17:20于 Andrew Cooper >> >写道： >>> > >>> > On 06/02/2018 09:13, Zhenzhong Duan wrote: >>> > > 在 2018/2/6 16:59, Andrew

Re: [Xen-devel] 回复: Re: [PATCH] Choose retpoline only when it is safe to use

在 2018/2/6 19:56, Andrew Cooper 写道: On 06/02/18 11:41, Zhenzhong Duan wrote: On 2018/2/6 18:50, Andrew Cooper wrote: On 06/02/18 10:29, zhenzhong.duan wrote: 2018年2月6日 17:20于 Andrew Cooper >写道： > > On 06/02/2018 09:13, Zhenzhong Duan wrote: > > 在 2018/2/6 1

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: > There are multiple issues here, and I'm happy to split the patch up if > that's what it takes: > - "set -e" on a separate Makefile line is meaningless. Glue together all > the lines that this is supposed to cover. > - I have no idea w

Re: [Xen-devel] [PATCH v3] libxc: don't fail domain creation when unpacking initrd fails

On Thu, Feb 01, 2018 at 12:22:43AM -0700, Jan Beulich wrote: > At least Linux kernels have been able to work with gzip-ed initrd for > quite some time; initrd compressed with other methods aren't even being > attempted to unpack. Furthermore the unzip-ing routine used here isn't > capable of dealin

Re: [Xen-devel] Problem with IOMEM and domain reboot

On Wed, Dec 20, 2017 at 06:27:02PM +0200, Oleksandr Andrushchenko wrote: > Hi, all! > > While trying to reboot a domain which has iomem configured > (we are passing through some devices), I found an issue, > that after domain reboot those iomem's are incorrectly re-mapped, > e.g. for the configura

Re: [Xen-devel] [PATCH] libxl: add libxl__is_driver_domain function

On Thu, Dec 14, 2017 at 04:14:12PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > We have following arm-based setup: > > - Dom0 with xen and xen tools; > - Dom1 with device backends (but it is not the driver domain); What is your definition of a "driver domain"? What does it do i

Re: [Xen-devel] Problem with IOMEM and domain reboot

Hi, Wei! On 02/06/2018 02:36 PM, Wei Liu wrote: On Wed, Dec 20, 2017 at 06:27:02PM +0200, Oleksandr Andrushchenko wrote: Hi, all! While trying to reboot a domain which has iomem configured (we are passing through some devices), I found an issue, that after domain reboot those iomem's are inco

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

>>> On 06.02.18 at 13:36, wrote: > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: >> - Excluding symlinks in the source tree is a problem for me: Short of >> out-of-tree builds, in order to easily build test multiple >> configurations, I'm setting up my build trees as trees of sy

Re: [Xen-devel] Problem with IOMEM and domain reboot

On Tue, Feb 06, 2018 at 02:44:56PM +0200, Oleksandr Andrushchenko wrote: > From aa1f20af73a5a3c8f2c904b857a79334d18d41ff Mon Sep 17 00:00:00 2001 > > > From: Oleksandr Andrushchenko > > > Date: Wed, 20 Dec 2017 17:51:18 +0200 > > > Subject: [PATCH] [HACK] Reset iomem's gfn to LIBXL_INVALID_GFN on

Re: [Xen-devel] [PATCH v4 4/7] libxl: support mapping static shared memory areas during domain creation

Hi, On 01/30/2018 05:50 PM, Zhongze Liu wrote: Add libxl__sshm_add to map shared pages from one DomU to another, The mapping process involves the follwing steps: s/follwing/following/ * Set defaults and check for further errors in the static_shm configs: overlapping areas, invalid r

Re: [Xen-devel] [PATCH] libxl: add libxl__is_driver_domain function

On Tue, Feb 6, 2018 at 2:36 PM, Wei Liu wrote: > On Thu, Dec 14, 2017 at 04:14:12PM +0200, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > We have following arm-based setup: > > > > - Dom0 with xen and xen tools; > > - Dom1 with device backends (but it is not the driver domain); > >

Re: [Xen-devel] 回复: Re: [PATCH] Choose retpoline only when it is safe to use

On 06/02/18 12:30, Zhenzhong Duan wrote: > 在 2018/2/6 19:56, Andrew Cooper 写道: >> On 06/02/18 11:41, Zhenzhong Duan wrote: >>> On 2018/2/6 18:50, Andrew Cooper wrote: On 06/02/18 10:29, zhenzhong.duan wrote: > > > 2018年2月6日 17:20于 Andrew Cooper

Re: [Xen-devel] [PATCH v4 5/7] libxl: support unmapping static shared memory areas during domain destruction

Hi, On 01/30/2018 05:50 PM, Zhongze Liu wrote: Add libxl__sshm_del to unmap static shared memory areas mapped by libxl__sshm_add during domain creation. The unmapping process is: * For a master: decrease the refcount of the sshm region, if the refcount reaches 0, cleanup the whole sshm path.

Re: [Xen-devel] [PATCH v4 7/7] docs: documentation about static shared memory regions

Hi, On 01/30/2018 05:50 PM, Zhongze Liu wrote: Add docs to document the motivation, usage, use cases and other relevant information about the static shared memory feature. This is for the proposal "Allow setting up shared memory areas between VMs from xl config file". See: https://lists.xen

[Xen-devel] [PATCH] x86/spec_ctrl: Fix determination of when to use IBRS

The original version of this logic was: /* * On Intel hardware, we'd like to use retpoline in preference to * IBRS, but only if it is safe on this hardware. */ else if ( boot_cpu_has(X86_FEATURE_IBRSB) ) { if ( retpoline_safe() ) thunk = THUNK_RETPOLI

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

On Tue, Feb 06, 2018 at 05:45:18AM -0700, Jan Beulich wrote: > >>> On 06.02.18 at 13:36, wrote: > > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: > >> - Excluding symlinks in the source tree is a problem for me: Short of > >> out-of-tree builds, in order to easily build test multi

Re: [Xen-devel] [PATCH v4 2/8] ARM: VGIC: split gic.c to observe hardware/virtual GIC separation

Hi, On 02/05/2018 04:19 PM, Andre Przywara wrote: diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c new file mode 100644 index 00..263b430075 --- /dev/null +++ b/xen/arch/arm/gic-vgic.c @@ -0,0 +1,396 @@ +/* + * xen/arch/arm/gic-vgic.c + * + * ARM Generic Interrupt Controlle

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

On 05/02/18 21:18, Igor Druzhinin wrote: > We're noticing a reproducible system boot hang on certain > post-Skylake platforms where the BIOS is configured in Its just a plain Skylake Server, from what I can see. > legacy boot mode with x2APIC disabled. The system stalls > immediately after writin

Re: [Xen-devel] [PATCH v4 5/8] ARM: VGIC: factor out vgic_connect_hw_irq()

Hi Andre, On 02/05/2018 04:19 PM, Andre Przywara wrote: At the moment we happily access VGIC internal data structures like the rank and struct pending_irq in gic.c, which should be VGIC agnostic. Factor out a new function vgic_connect_hw_irq(), which allows a virtual IRQ to be connected to a ha

Re: [Xen-devel] [PATCH v4 6/8] ARM: VGIC: factor out vgic_get_hw_irq_desc()

Hi Andre, On 02/05/2018 04:19 PM, Andre Przywara wrote: At the moment we happily access the VGIC internal struct pending_irq (which describes a virtual IRQ) in irq.c. Factor out the actually needed functionality to learn the associated hardware IRQ and move that into gic-vgic.c to improve abstra

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

On 06/02/18 03:10, Alexey G wrote: > On Mon, 5 Feb 2018 21:18:42 + > Igor Druzhinin wrote: > >> We're noticing a reproducible system boot hang on certain >> post-Skylake platforms where the BIOS is configured in >> legacy boot mode with x2APIC disabled. The system stalls >> immediately after w

Re: [Xen-devel] [PATCH v1 3/6] libxl: add backend type and id to vkb

On Wed, Nov 01, 2017 at 05:05:04PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > New field backend_type is added to vkb device > in order to have QEMU and user space backend > simultaneously. Each vkb backend shall read > appropriate XS entry and service only own > frontends. > Id

Re: [Xen-devel] [PATCH v1 4/6] libxl: vkb add list and info functions

On Wed, Nov 01, 2017 at 05:05:05PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v1 4/6] libxl: vkb add list and info functions

On Wed, Nov 01, 2017 at 05:05:05PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v1 5/6] xl: add vkb config parser and CLI

On Wed, Nov 01, 2017 at 05:05:06PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v1 6/6] docs: add vkb device to xl.cfg and xl

On Wed, Nov 01, 2017 at 05:05:07PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] xenbus: track caller request id

On 02/02/18 18:42, Joao Martins wrote: > Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent > xenstore accesses") optimized xenbus concurrent accesses but in doing so > broke UABI of /dev/xen/xenbus. Through /dev/xen/xenbus applications are in > charge of xenbus message excha

Re: [Xen-devel] [PATCH v4 5/8] ARM: VGIC: factor out vgic_connect_hw_irq()

On 02/06/2018 02:21 PM, Julien Grall wrote: Hi Andre, On 02/05/2018 04:19 PM, Andre Przywara wrote: At the moment we happily access VGIC internal data structures like the rank and struct pending_irq in gic.c, which should be VGIC agnostic. Factor out a new function vgic_connect_hw_irq(), which

Re: [Xen-devel] [PATCH v1 5/5] docs: add PV sound device config

On Wed, Nov 01, 2017 at 05:04:47PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Update documentation with virtual sound device > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenpro

Re: [Xen-devel] [PATCH v1 3/5] xl: add PV sound condif parser

On Wed, Nov 01, 2017 at 05:04:45PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add config parser for virtual sound devices > > Signed-off-by: Oleksandr Grytsov > + > +int parse_vsnd_item(libxl_device_vsnd *vsnd, const char *spec) > +{ > +char *buf = strdup(spec); > +ch

Re: [Xen-devel] [PATCH v1 1/5] libxl: add PV sound device

On Wed, Nov 01, 2017 at 05:04:43PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add PV sound device described in sndif.h > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu (I haven't checked if the values used in the IDL are the same in the spec) ___

Re: [Xen-devel] [PATCH v1 2/5] libxl: add vsnd list and info

On Wed, Nov 01, 2017 at 05:04:44PM +0200, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add getting vsnd list amd info API > > Signed-off-by: Oleksandr Grytsov > --- > tools/libxl/libxl.h | 10 ++ > tools/libxl/libxl_types.idl | 19 +++ > tools/libxl/libxl_utils.h | 3 +

Re: [Xen-devel] [PATCH v2 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

On 02/02/2018 03:40 PM, Volodymyr Babchuk wrote: Hi Hi, On 02.02.18 16:31, Julien Grall wrote: Hi, On 02/02/18 14:23, Volodymyr Babchuk wrote: On 02.02.18 13:41, Julien Grall wrote: At the moment PSCI function dispatching is done in vsmc.c and the function implementation in vpsci.c. So

Re: [Xen-devel] [PATCH] pvcalls-back: do not return error on inet_accept EAGAIN

On 03/02/18 02:34, Stefano Stabellini wrote: > When the client sends a regular blocking accept request, the backend is > expected to return only when the accept is completed, simulating a > blocking behavior, or return an error. > > Specifically, on EAGAIN from inet_accept, the backend shouldn't r

Re: [Xen-devel] [PATCH 0/2] Fix a couple of crashes in netfront

On 11/01/18 10:36, Ross Lagerwall wrote: > Here are a couple of patches to fix two crashes in netfront. > > Ross Lagerwall (2): > xen/grant-table: Use put_page instead of free_page > xen-netfront: Fix race between device setup and open > > drivers/net/xen-netfront.c | 46 > +

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: vsmc: Don't implement function ID that doesn't exist

Hi Volodymyr, On 02/02/2018 01:46 PM, Volodymyr Babchuk wrote: On 02.02.18 13:41, Julien Grall wrote: The current implementation of SMCCC relies on the fact only function number (bits [15:0]) is enough to identify what to implement. However, PSCI call are only available in the range 0x84

Re: [Xen-devel] Xen Project Spectre / Meltdown FAQ (Jan 22 Update)

> On Jan 22, 2018, at 11:18, Lars Kurth wrote: > > Hi all, > I will post the following new version of the FAQ on > https://blog.xenproject.org/ in a moment. As there are tables in it, I will > post as PDF rather than text. This thread is primarily a placeholder to post > further questions abou

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: vsmc: Don't implement function ID that doesn't exist

Hi Julien, On 06.02.18 16:53, Julien Grall wrote: Hi Volodymyr, On 02/02/2018 01:46 PM, Volodymyr Babchuk wrote: On 02.02.18 13:41, Julien Grall wrote: The current implementation of SMCCC relies on the fact only function number (bits [15:0]) is enough to identify what to implement. However

Re: [Xen-devel] [PATCH v2 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

Hi Julien, On 06.02.18 16:45, Julien Grall wrote: [...] +/* + * PSCI 0.2 or later calls. It will return false if the function ID is + * not handled. + */ +bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid) +{ +    /* + * /!\ VPSCI_NR_FUNCS (in asm-arm/vpsci.h) should be upda

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: vsmc: Don't implement function ID that doesn't exist

On 02/06/2018 03:15 PM, Volodymyr Babchuk wrote: Hi Julien, Hi, On 06.02.18 16:53, Julien Grall wrote: On 02/02/2018 01:46 PM, Volodymyr Babchuk wrote: On 02.02.18 13:41, Julien Grall wrote: The current implementation of SMCCC relies on the fact only function number (bits [15:0]) is enou

Re: [Xen-devel] [PATCH v2 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

On 02/06/2018 03:28 PM, Volodymyr Babchuk wrote: Hi Julien, On 06.02.18 16:45, Julien Grall wrote: [...] +/* + * PSCI 0.2 or later calls. It will return false if the function ID is + * not handled. + */ +bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid) +{ +    /* + * /!

Re: [Xen-devel] [PATCH v4 3/7] libxl: introduce a new structure to represent static shared memory regions

Hi Julien, Thanks for reviewing. 2018-02-06 19:27 GMT+08:00 Julien Grall : > Hi, > > On 01/30/2018 05:50 PM, Zhongze Liu wrote: >> >> Add a new structure to the IDL familiy to represent static shared memory >> regions [...] >> +libxl_static_shm = Struct("static_shm", [ >> +("id", string), >

Re: [Xen-devel] [PATCH 1/7] xen/arm: vpsci: Remove parameter 'ver' from do_common_cpu

Hi Julien, On 5 February 2018 at 15:20, Julien Grall wrote: > Currently, the behavior of do_common_cpu will slightly change depending > on the PSCI version passed in parameter. Looking at the code, more the > specific 0.2 behavior could move out of the function or adapted for 0.1: > > - x0/r0

Re: [Xen-devel] [PATCH v4 5/8] ARM: VGIC: factor out vgic_connect_hw_irq()

Hi, On 06/02/18 14:21, Julien Grall wrote: > Hi Andre, > > On 02/05/2018 04:19 PM, Andre Przywara wrote: >> At the moment we happily access VGIC internal data structures like >> the rank and struct pending_irq in gic.c, which should be VGIC agnostic. >> >> Factor out a new function vgic_connect_h

Re: [Xen-devel] [PATCH v4 3/7] libxl: introduce a new structure to represent static shared memory regions

Hi, On 02/06/2018 03:41 PM, Zhongze Liu wrote: Thanks for reviewing. 2018-02-06 19:27 GMT+08:00 Julien Grall : Hi, On 01/30/2018 05:50 PM, Zhongze Liu wrote: Add a new structure to the IDL familiy to represent static shared memory regions [...] +libxl_static_shm = Struct("static_shm", [

Re: [Xen-devel] [PATCH v4 5/8] ARM: VGIC: factor out vgic_connect_hw_irq()

On 02/06/2018 03:44 PM, Andre Przywara wrote: Hi, On 06/02/18 14:21, Julien Grall wrote: Hi Andre, On 02/05/2018 04:19 PM, Andre Przywara wrote: At the moment we happily access VGIC internal data structures like the rank and struct pending_irq in gic.c, which should be VGIC agnostic. Facto

Re: [Xen-devel] [PATCH v2 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

On 06.02.18 17:39, Julien Grall wrote: On 02/06/2018 03:28 PM, Volodymyr Babchuk wrote: Hi Julien, On 06.02.18 16:45, Julien Grall wrote: [...] +/* + * PSCI 0.2 or later calls. It will return false if the function ID is + * not handled. + */ +bool do_vpsci_0_2_call(struct cpu_user_regs

[Xen-devel] [PATCH v3 2/3] xen/arm: vsmc: Don't implement function ID that doesn't exist

The current implementation of SMCCC relies on the fact only function number (bits [15:0]) is enough to identify what to implement. However, PSCI call are only available in the range 0x8400-0x841F and 0xC400-0xC41F. Furthermore, not all SMC32 functions have equivalent in the SMC64.

[Xen-devel] [PATCH v3 1/3] xen/arm: vpsci: Removing dummy MIGRATE and MIGRATE_INFO_UP_CPU

The PSCI call MIGRATE and MIGRATE_INFO_UP_CPU are optional and implemented as just returning PSCI_NOT_SUPPORTED (aka UNKNOWN_FUNCTION for SMCCC). The new SMCCC framework is able to deal with unimplemented function and return the proper error code. So remove the implementations for both function.

[Xen-devel] [PATCH v3 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

At the moment PSCI function dispatching is done in vsmc.c and the function implementation in vpsci.c. Some bits of the implementation is even done in vsmc.c (see PSCI_SYSTEM_RESET). This means that it is difficult to follow the implementation and also requires to export functions for each PSCI fun

[Xen-devel] [PATCH v3 0/3] xen/arm: SMCCC fixes and PSCI clean-up

Hi all, This small patch series contains SMCCC fixes (see #2) and PSCI clean-up. Cheers, Julien Grall (3): xen/arm: vpsci: Removing dummy MIGRATE and MIGRATE_INFO_UP_CPU xen/arm: vsmc: Don't implement function ID that doesn't exist xen/arm: vpsci: Move PSCI function dispatching from vsmc.c

Re: [Xen-devel] [PATCH 2/7] xen/arm: psci: Rework the PSCI definitions

Hi, On 5 February 2018 at 15:20, Julien Grall wrote: > Some PSCI functions are only available in the 32-bit version. After > recent changes, Xen always needs to know whether the call was made using > 32-bit id or 64-bit id. So we don't emulate reserved one. > > With the current naming scheme, it

Re: [Xen-devel] [PATCH v4 4/7] libxl: support mapping static shared memory areas during domain creation

Hi Julien, 2018-02-06 21:07 GMT+08:00 Julien Grall : > Hi, > > On 01/30/2018 05:50 PM, Zhongze Liu wrote: >> >> Add libxl__sshm_add to map shared pages from one DomU to another, The >> mapping >> process involves the follwing steps: [...] >> + >> +/* Set default values for libxl_static_shm */ >>

Re: [Xen-devel] [PATCH v4 3/7] libxl: introduce a new structure to represent static shared memory regions

Hi, 2018-02-06 23:46 GMT+08:00 Julien Grall : > Hi, > > On 02/06/2018 03:41 PM, Zhongze Liu wrote: >> >> Thanks for reviewing. >> >> 2018-02-06 19:27 GMT+08:00 Julien Grall : >>> >>> Hi, >>> >>> On 01/30/2018 05:50 PM, Zhongze Liu wrote: Add a new structure to the IDL familiy to rep

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

>>> On 05.02.18 at 22:18, wrote: > --- a/xen/arch/x86/nmi.c > +++ b/xen/arch/x86/nmi.c > @@ -34,7 +34,8 @@ > #include > > unsigned int nmi_watchdog = NMI_NONE; > -static unsigned int nmi_hz = HZ; > +/* initial watchdog frequency - shouldn't be too high to avoid boot hangs */ > +static unsigne

Re: [Xen-devel] [PATCH 3/7] xen/arm: vpsci: Add support for PSCI 1.1

Hi, On 5 February 2018 at 15:20, Julien Grall wrote: > At the moment, Xen provides virtual PSCI interface compliant with 0.1 > and 0.2. Since them, the specification has been updated and the latest > version is 1.1 (see ARM DEN 0022D). > > From an implementation point of view, only PSCI_FEATURES

[Xen-devel] CfP 13th Virtualization in High­-Performance Cloud Computing Workshop (VHPC '18)

*CALL FOR PAPERS 13th Workshop on Virtualization in High­-Performance Cloud Computing (VHPC '18)held in conjunction with the International Supercomputing Conference - High Performance,June 24-28, 2018, Frankfurt, Germany.(Springer

Re: [Xen-devel] [PATCH] x86/spec_ctrl: Fix determination of when to use IBRS

>>> On 06.02.18 at 14:48, wrote: > The original version of this logic was: > > /* > * On Intel hardware, we'd like to use retpoline in preference to > * IBRS, but only if it is safe on this hardware. > */ > else if ( boot_cpu_has(X86_FEATURE_IBRSB) ) > { > if (

[Xen-devel] [xen-unstable test] 118607: tolerable FAIL - PUSHED

flight 118607 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/118607/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-rumprun-i386 17 rumprun-demo-xenstorels/xenstorels.repeat fail REGR. vs. 118582 Tests whi

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

On 06/02/18 16:07, Jan Beulich wrote: On 05.02.18 at 22:18, wrote: >> --- a/xen/arch/x86/nmi.c >> +++ b/xen/arch/x86/nmi.c >> @@ -34,7 +34,8 @@ >> #include >> >> unsigned int nmi_watchdog = NMI_NONE; >> -static unsigned int nmi_hz = HZ; >> +/* initial watchdog frequency - shouldn't be to

Re: [Xen-devel] [PATCH 4/7] xen/arm: vsmc: Implement SMCCC 1.1

On 5 February 2018 at 15:20, Julien Grall wrote: > The new SMC Calling Convention (v1.1) allows for a reduced overhead when > calling into the firmware, and provides a new feature discovery > mechanism. See ARM DEN 00070A. Сould you please use also a human-readable document name? I remember that I

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

>>> On 06.02.18 at 17:14, wrote: > On 06/02/18 16:07, Jan Beulich wrote: > On 05.02.18 at 22:18, wrote: >>> --- a/xen/arch/x86/nmi.c >>> +++ b/xen/arch/x86/nmi.c >>> @@ -34,7 +34,8 @@ >>> #include >>> >>> unsigned int nmi_watchdog = NMI_NONE; >>> -static unsigned int nmi_hz = HZ; >>> +/*

Re: [Xen-devel] [PATCH 5/7] xen/arm: vsmc: Implement SMCCC_ARCH_WORKAROUND_1 BP hardening support

Hi, On 5 February 2018 at 15:20, Julien Grall wrote: > SMCCC 1.1 offers firmware-based CPU workarounds. In particular, > SMCCC_ARCH_WORKAROUND_1 provides BP hardening for variant 2 of XSA-254 > (CVE-2017-5715). > > If the hypervisor has some mitigation for this issue, report that we > deal with i

Re: [Xen-devel] [PATCH 6/7] xen/arm: Adapt smccc.h to be able to use it in assembly code

Hi, On 5 February 2018 at 15:20, Julien Grall wrote: > Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk > --- > xen/include/asm-arm/smccc.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/xen/include/asm-arm/smccc.h b/xen/include/asm-arm/sm

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

On 06/02/18 16:23, Jan Beulich wrote: On 06.02.18 at 17:14, wrote: >> On 06/02/18 16:07, Jan Beulich wrote: >> On 05.02.18 at 22:18, wrote: --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -34,7 +34,8 @@ #include unsigned int nmi_watchdog = NMI_NONE

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

On 06/02/18 16:23, Jan Beulich wrote: On 06.02.18 at 17:14, wrote: >> On 06/02/18 16:07, Jan Beulich wrote: >> On 05.02.18 at 22:18, wrote: --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -34,7 +34,8 @@ #include unsigned int nmi_watchdog = NMI_NONE

Re: [Xen-devel] [PATCH 7/7] xen/arm64: Implement a fast path for handling SMCCC_ARCH_WORKAROUND_1

Hi, On 5 February 2018 at 15:20, Julien Grall wrote: > The function SMCCC_ARCH_WORKAROUND_1 will be called by the guest for > hardening the branch predictor. So we want the handling to be as fast as > possible. > > As the mitigation is applied on every guest exit, we can check for the > call befo

Re: [Xen-devel] [PATCH v3 3/3] xen/arm: vpsci: Move PSCI function dispatching from vsmc.c to vpsci.c

Hi, On 06.02.18 17:53, Julien Grall wrote: At the moment PSCI function dispatching is done in vsmc.c and the function implementation in vpsci.c. Some bits of the implementation is even done in vsmc.c (see PSCI_SYSTEM_RESET). This means that it is difficult to follow the implementation and also

Re: [Xen-devel] Xen ARM community call Tuesday 13th February 5PM UTC

> As we do not have Jira access, it would be better to do it on Wiki or > "something else". The project has Jira access and can give selected community members write access Read access is not an issue Lars On 06/02/2018, 11:22, "Artem Mygaiev" wrote: Hi Lars As we do not

Re: [Xen-devel] [PATCH v1 3/6] libxl: add backend type and id to vkb

On Tue, Feb 6, 2018 at 4:25 PM, Wei Liu wrote: > On Wed, Nov 01, 2017 at 05:05:04PM +0200, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > New field backend_type is added to vkb device > > in order to have QEMU and user space backend > > simultaneously. Each vkb backend shall read >

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Tue, Jan 30, 2018 at 10:55:47PM +, Michael Young wrote: > Xen built with ocaml 4.06 gives errors such as > Error: This expression has type bytes but an expression was > expected of type string > as Byte and safe-strings which were introduced in 4.02 are the > default in 4.06. > This pa

Re: [Xen-devel] [PATCH v1 3/6] libxl: add backend type and id to vkb

On Tue, Feb 06, 2018 at 06:45:15PM +0200, Oleksandr Grytsov wrote: > > > +static int libxl__set_xenstore_vkb(libxl__gc *gc, uint32_t domid, > > > + libxl_device_vkb *vkb, > > > + flexarray_t *back, flexarray_t > > *front, > > > +

Re: [Xen-devel] [PATCH 1/3] Make credit2 the default scheduler

On 02/06/2018 06:18 AM, Juergen Gross wrote: > On 05/02/18 17:53, Dario Faggioli wrote: >> On Mon, 2018-02-05 at 13:01 +, George Dunlap wrote: >>> And in any case, making those improvements >>> on credit2 will be easier than on credit. >>> >> And, if possible, I agree with George on this even m

Re: [Xen-devel] [PATCH] x86/nmi: lower initial watchdog frequency to avoid boot hangs

On Tue, 6 Feb 2018 14:21:12 + Andrew Cooper wrote: >On 06/02/18 03:10, Alexey G wrote: >> I/O port 61h normally is not emulated by SMI legacy kbd handling code >> in BIOS, only ports like 60h, 64h, etc. >> Contrary to USB legacy emulation, it has to intercept port 61h via a >> different appro

  1   2   >