Re: [Xen-devel] [PATCH 4/5] x86: use switch() in _put_page_type()

2017-12-05 Thread Jan Beulich
>>> On 04.12.17 at 16:40, wrote: > On 04/12/17 10:46, Jan Beulich wrote: >> Use this to cheaply add another assertion. >> >> Signed-off-by: Jan Beulich >> --- >> TBD: Would it perhaps be better to return after the assertion? > > Yes, otherwise we risk falling into an infinite continue loop. I'v

[Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116832 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/116832/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 10 windows-install fail REGR. vs. 116744 Tests which did no

Re: [Xen-devel] [PATCH v2] x86/hvm: Add MSR old value

2017-12-05 Thread Jan Beulich
>>> On 04.12.17 at 16:45, wrote: >> On Fri, Oct 13, 2017 at 03:50:57PM +0300, Alexandru Isaila wrote: >>> This patch adds the old value param and the onchangeonly option >>> to the VM_EVENT_REASON_MOV_TO_MSR event. >>> >>> The param was added to the vm_event_mov_to_msr struct and to the >>> hvm_m

Re: [Xen-devel] [PATCH v9 00/16] Enable Memory Bandwidth Allocation in Xen

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 03:53, wrote: > This patch set has got all Acked-by/Reviewed-by months ago. So, I am > wondering when it can be integrated? Any plan? Thanks! It is not being forgotten. But the tree is not fully open yet, so it is subject to the judgment of committers whether any patch (or seri

Re: [Xen-devel] [RFC v3 1/4] Port WARN_ON_ONCE() from Linux

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 04:59, wrote: > Port WARN_ON_ONCE macro from Linux. A return value is expected from this > macro, so the implementation does not follow the Xen convention of wrapping > macros in a do..while. There's no such convention for macros producing a value. > --- Missing S-o-b. > --

Re: [Xen-devel] [RFC v3 2/4] xen/linux_compat: Add a Linux compat header

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 04:59, wrote: > For porting files from Linux it is useful to have a Linux API to Xen API > mapping header at a common location. Looking at what you add here I really think "no, please don't". But let's see what other maintainers thinks. Jan __

Re: [Xen-devel] [PATCH v9 00/16] Enable Memory Bandwidth Allocation in Xen

2017-12-05 Thread Yi Sun
On 17-12-05 02:09:14, Jan Beulich wrote: > >>> On 05.12.17 at 03:53, wrote: > > This patch set has got all Acked-by/Reviewed-by months ago. So, I am > > wondering when it can be integrated? Any plan? Thanks! > > It is not being forgotten. But the tree is not fully open yet, so it is > subject to

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 09:49, wrote: > flight 116832 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116832/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-xl-qemut-win7-amd64 10 windows

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Andrew Cooper
On 05/12/2017 09:30, Jan Beulich wrote: On 05.12.17 at 09:49, wrote: >> flight 116832 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/116832/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >>

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Andrew Cooper
On 05/12/2017 10:03, Andrew Cooper wrote: > On 05/12/2017 09:30, Jan Beulich wrote: > On 05.12.17 at 09:49, wrote: >>> flight 116832 xen-unstable real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/116832/ >>> >>> Regressions :-( >>> >>> Tests which did not succeed and are blocki

[Xen-devel] [seabios test] 116836: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116836 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/116836/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not suc

[Xen-devel] [libvirt test] 116849: tolerable all pass - PUSHED

2017-12-05 Thread osstest service owner
flight 116849 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/116849/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 116770 test-armhf-armhf-libvirt-raw 13 saveresto

[Xen-devel] xen 4.8.2 iommu=off problems

2017-12-05 Thread James Dingwall
Hi, We have 3x HPE DL180 Gen9 servers, one of these is dual CPU the others single. They are all running the same xen 4.8.2 build (plus some XSA patches) and Linux 4.1.46 dom0/guest kernel. On the single CPU systems we can successfully passthrough ports from the onboard controller (igb) and a

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Oleksandr Tyshchenko
Hi Stefano On Tue, Dec 5, 2017 at 12:18 AM, Stefano Stabellini wrote: > On Sat, 2 Dec 2017, Oleksandr Tyshchenko wrote: >> On Sat, Dec 2, 2017 at 3:06 AM, Stefano Stabellini >> wrote: >> > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: >> >> From: Oleksandr Dmytryshyn >> >> >> >> This settings

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-05 Thread Julien Grall
Hi, On 04/12/17 22:04, Stefano Stabellini wrote: On Mon, 4 Dec 2017, Volodymyr Babchuk wrote: Hi Julien, On Mon, Dec 04, 2017 at 04:27:14PM +, Julien Grall wrote: [...] = Error checking / DOS protection = We need powerful checks on arguments passed by the caller and evaluated by the me

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 11:03, wrote: > On 05/12/2017 09:30, Jan Beulich wrote: > On 05.12.17 at 09:49, wrote: >>> flight 116832 xen-unstable real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/116832/ >>> >>> Regressions :-( >>> >>> Tests which did not succeed and are blocking, >>>

Re: [Xen-devel] [RFC PATCH 13/31] xen/arm: Add driver_data field to struct device

2017-12-05 Thread Julien Grall
On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Please explain the rationale behind adding a new field in struct device. Signed-off-by: Oleksandr Tyshchenko CC: Stefano Stabellini CC: Julien Grall --- xen/include/asm-arm/device.h | 1 + 1 file changed, 1 in

Re: [Xen-devel] [RFC v3 2/4] xen/linux_compat: Add a Linux compat header

2017-12-05 Thread Julien Grall
Hi Jan, On 05/12/17 09:20, Jan Beulich wrote: On 05.12.17 at 04:59, wrote: For porting files from Linux it is useful to have a Linux API to Xen API mapping header at a common location. Looking at what you add here I really think "no, please don't". But let's see what other maintainers thinks

[Xen-devel] Xen 4.10 RC8

2017-12-05 Thread Julien Grall
Hi all, Xen 4.10 RC8 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.10.0-rc8 For your convenience, there is also a tarball at: https://downloads.xenproject.org/release/xen/4.10.0-rc8/xen-4.10.0-rc8.tar.gz And the signature is at: https://downloads.xenproject.o

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Andrew Cooper
On 05/12/17 11:16, Jan Beulich wrote: On 05.12.17 at 11:03, wrote: >> On 05/12/2017 09:30, Jan Beulich wrote: >> On 05.12.17 at 09:49, wrote: flight 116832 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/116832/ Regressions :-( Tes

[Xen-devel] [OSSTEST PATCH] production-config: Increase LogsMinSpaceMby etc.

2017-12-05 Thread Ian Jackson
osstest does not currently try to estimate the prospective disk use in logs/ etc. of a flight before it starts; nor does it aggregate the disk requirements of multiple concurrent flights. Instead, it has a hardcoded minimum, which is enforced (by expiry) at the start of each flight. It must be la

Re: [Xen-devel] [patch 01/60] x86/entry/64/paravirt: Use paravirt-safe macro to access eflags

2017-12-05 Thread Juergen Gross
On 04/12/17 15:07, Thomas Gleixner wrote: > From: Boris Ostrovsky > > Commit 1d3e53e8624a ("x86/entry/64: Refactor IRQ stacks and make them > NMI-safe") added DEBUG_ENTRY_ASSERT_IRQS_OFF macro that acceses eflags > using 'pushfq' instruction when testing for IF bit. On PV Xen guests > looking at

Re: [Xen-devel] [RFC v3 2/4] xen/linux_compat: Add a Linux compat header

2017-12-05 Thread Julien Grall
Hi Sameer, On 05/12/17 03:59, Sameer Goel wrote: For porting files from Linux it is useful to have a Linux API to Xen API mapping header at a common location. This file adds common API functions and other defines that are needed for porting arm SMMU drivers. --- xen/include/xen/linux_compat.h

Re: [Xen-devel] [RFC PATCH 13/31] xen/arm: Add driver_data field to struct device

2017-12-05 Thread Oleksandr Tyshchenko
Hi, Julien. On Tue, Dec 5, 2017 at 1:26 PM, Julien Grall wrote: > > > On 09/11/17 17:10, Oleksandr Tyshchenko wrote: >> >> From: Oleksandr Tyshchenko > > > Please explain the rationale behind adding a new field in struct device. Basically it is needed for the "direct ported" drivers from Linux.

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-05 Thread Volodymyr Babchuk
Hi Stefano, On 05.12.17 00:06, Stefano Stabellini wrote: On Mon, 4 Dec 2017, Volodymyr Babchuk wrote: = Xen command forwarding = In the code below, it looks like Xen is forwarding everything to OP-TEE. Are there some commands Xen should avoid forwarding? Should we have a whitelist or a blackl

[Xen-devel] [distros-debian-snapshot test] 72518: tolerable FAIL

2017-12-05 Thread Platform Team regression test user
flight 72518 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72518/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-i386-daily-netboot-pygrub 11 guest-start fail blocked in 72497 test-amd64-amd64-amd64

[Xen-devel] [qemu-mainline test] 116846: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116846 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/116846/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 5 host-ping-check-native fail REGR. vs. 116683 test-amd64-amd64-

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Jan Beulich
>>> On 28.11.17 at 15:05, wrote: > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -88,7 +88,7 @@ bool hvm_emulate_one_insn(hvm_emulate_validate_t *validate, > const char *descr) > > rc = hvm_emulate_one(&ctxt); > > -if ( hvm_vcpu_io_need_completion(vio) || vio->mmio_r

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 13:53 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org > Subject: Re: [PATCH v2] x86/hvm: fix interaction between internal and > external emulation > > >>> On 28.11.17 at 15:05, wrote: > >

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 05 December 2017 14:00 > To: 'Jan Beulich' > Cc: xen-devel@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between > internal and e

Re: [Xen-devel] [RFC v3 4/4] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-12-05 Thread Julien Grall
Hello, On 05/12/17 03:59, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced in headers to bridge the API calls. - Called Linux functions from the Xen IOMMU function calls. - Xen m

Re: [Xen-devel] [RFC PATCH 09/31] xen/device-tree: Add dt_property_for_each_string macros

2017-12-05 Thread Oleksandr Tyshchenko
Hi, Stefano On Tue, Dec 5, 2017 at 1:24 AM, Stefano Stabellini wrote: > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This is a port from Linux. > > When you port stuff from Linux you have to retain the original > copyright. Please add the original Signed-of

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 15:00, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 05 December 2017 13:53 >> >>> On 28.11.17 at 15:05, wrote: >> rc = x86_emulate(&hvmemul_ctxt->ctxt, ops); >> >> if ( rc != X86EMUL_RETRY ) >> { >> vio->mmio_cache_count = 0; >> v

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 15:11, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Paul Durrant >> Sent: 05 December 2017 14:00 >> To: 'Jan Beulich' >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 05 December 2017 13:53 >> > >>> On 28.11.17 at 15:05,

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 14:32 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org > Subject: RE: [PATCH v2] x86/hvm: fix interaction between internal and > external emulation > > >>> On 05.12.17 at 15:00, wrote: > >

[Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Dan Carpenter
Smatch complains that "len" is uninitialized if xenbus_read() fails so let's add some error handling. Signed-off-by: Dan Carpenter diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index 40caa92bff33..afa3f1b5d807 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pv

[Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Dan Carpenter
bedata->ref can't be less than zero because it's unsigned. This affects certain error paths in probe. We first set ->ref = -1 and then we set it to a valid value later. Fixes: 219681909913 ("xen/pvcalls: connect to the backend") Signed-off-by: Dan Carpenter diff --git a/drivers/xen/pvcalls-fro

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Ian Jackson
osstest service owner writes ("[xen-unstable test] 116832: regressions - FAIL"): > flight 116832 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116832/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > t

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Julien Grall
Hi Oleksandr, On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Volodymyr Babchuk Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existing use in PSCI code, but TEE mediator will need a call that is fully compatible with ARM SMCCC. Thi

Re: [Xen-devel] [PATCH v17 18/19] osstest: expand the list of tested disk controllers

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 18/19] osstest: expand the list of tested disk controllers"): > The Mass osstest instance has a more diverse list of hardware disk > controllers, so expand the list in order to include all the possible > disk drivers. Acked-by: Ian Jackson On the same basis a

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL"): > This is a blue screen, recurring, and has first been reported in flight > 116779, i.e. was likely introduced in the batch ending in commit > 4cd0fad645. Among those the most likely candidates appear to be > th

Re: [Xen-devel] [PATCH v17 17/19] osstest: remove the loader timeout from the install image

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 17/19] osstest: remove the loader timeout from the install image"): > When the FreeBSD installer is booted on the godello{0/1} boxes it > receives spurious key strokes. This doesn't happen so far when booted > from disk, or with any other boxes. > > In order to

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets"): > Due to a recent FreeBSD change the default output directory of the release > targets is changed to the object directory instead of the source > directory. Use WITHOUT_AUTO_OBJ to restore pr

[Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Julien Grall
Hi Juergen, On 04/12/17 15:49, Juergen Gross wrote: On 21/11/17 12:06, Juergen Gross wrote: The "special pages" for PVH guests include the frames for console and Xenstore ring buffers. Those have to be marked as "Reserved" in the guest's E820 map, as otherwise conflicts might arise later e.g. w

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Oleksandr Tyshchenko
On Mon, Dec 4, 2017 at 1:58 PM, Andre Przywara wrote: > Hi, Hi Andre > > > >> And the most important question is how to recognize in Xen on ARM >> (using SCPI protocol) which frequencies are turbo-frequencies >> actually? I couldn't find any information regarding that in protocol >> descript

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 16:05, wrote: > Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions > - > FAIL"): >> This is a blue screen, recurring, and has first been reported in flight >> 116779, i.e. was likely introduced in the batch ending in commit >> 4cd0fad645. Among those

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Volodymyr Babchuk
Hi Stefano, On Mon, Dec 04, 2017 at 06:30:13PM -0800, Stefano Stabellini wrote: > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > > From: Volodymyr Babchuk > > > > Existing SMC wrapper call_smc() allows only 4 parameters and > > returns only one value. This is enough for existing > > use in PS

[Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Ian Jackson
Julien Grall writes ("[for-4.10] Re: [Xen-devel] [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH"): > I would recommend to tag your patch is 4.10 to help reviewers prioritize > review on your patch. I have done it now. Thanks. Looking at the thread, I would have liked

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]"): > Oh, that's pretty unfortunate. I think we'll then need a custom flight > tied to the box that this failure occurred on, to have a way to tell > whether the fix I'm about to prepare has ac

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-12-05 Thread Julien Grall
Hi, Ping? This is going to be very helpful for bringing up osstest on Thunder-X. Cheers, On 02/11/17 13:34, Julien Grall wrote: Hi, On 23/10/17 22:33, Stefano Stabellini wrote: On Fri, 20 Oct 2017, Julien Grall wrote:    Julien, do you think we need to keep a special linux tree around f

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Andrew Cooper
On 05/12/17 15:31, Jan Beulich wrote: On 05.12.17 at 16:05, wrote: >> Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions >> - >> FAIL"): >>> This is a blue screen, recurring, and has first been reported in flight >>> 116779, i.e. was likely introduced in the batch

[Xen-devel] [OSSTEST PATCH] README.dev: Say how to do a commissioning flight for a new architecture

2017-12-05 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README.dev | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.dev b/README.dev index dc0dafd..37e2953 100644 --- a/README.dev +++ b/README.dev @@ -132,6 +132,13 @@ If that works, a more thorough test: This should show no regressions. (Or, at least,

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-05 Thread Stuart Yoder
There are limit on pCPUs, though. But this is not a problem, because XEN scheduler will decide which guest will access OP-TEE right now. OP-TEE don't have own scheduler at all, by the way. It is scheduled by normal world. Do you mind to give a bit more explanation here? Do you plan to add know

[Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Jan Beulich
vio->mmio_retry is being set when a repeated string insn is being split up. In that case we'll exit to the guest, expecting immediate re-entry. Interruptions, however, may be serviced by the guest before re-entry from the repeated string insn. Any emulation needed in the course of handling the inte

Re: [Xen-devel] [PATCH v6 00/16] xen: common: rbtree: ported updates from Linux tree

2017-12-05 Thread Praveen Kumar
Hi All, Can you please provide your comments over the changes shared. Thanks in advance. Regards, ~Praveen. On Tue, Nov 21, 2017 at 8:49 PM, Praveen Kumar wrote: > Hi All, > > The patch imports the changes and updates of the rbtree implementaiton > from Linux tree. But since, the only current

Re: [Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Juergen Gross
On 05/12/17 16:23, Julien Grall wrote: > Hi Juergen, > > On 04/12/17 15:49, Juergen Gross wrote: >> On 21/11/17 12:06, Juergen Gross wrote: >>> The "special pages" for PVH guests include the frames for console and >>> Xenstore ring buffers. Those have to be marked as "Reserved" in the >>> guest's

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Roger Pau Monné
On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ > with FreeBSD release targets"): > > Due to a recent FreeBSD change the default output directory of the release > > targets is changed to the object directory

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Juergen Gross
On 05/12/17 15:38, Dan Carpenter wrote: > bedata->ref can't be less than zero because it's unsigned. This affects > certain error paths in probe. We first set ->ref = -1 and then we set > it to a valid value later. > > Fixes: 219681909913 ("xen/pvcalls: connect to the backend") > Signed-off-by:

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Juergen Gross
On 05/12/17 15:38, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-dev

Re: [Xen-devel] [RFC PATCH v4] xen: credit2: provide custom option to create runqueue

2017-12-05 Thread Praveen Kumar
On Tue, Sep 5, 2017 at 11:26 PM, Dario Faggioli wrote: > On Fri, 2017-06-09 at 18:41 +0200, Dario Faggioli wrote: >> Hey Praveen, >> > Hey, hello again! > >> Here we are, sorry for the delay. >> > So, about this patch... I haven't seen a new version (or did I perhaps > miss it?). > > I'm asking be

[Xen-devel] [linux-linus test] 116840: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116840 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/116840/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 115643 test-amd64-am

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 16:14 > To: xen-devel > Cc: Julien Grall ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH] x86/HVM: don't retain emulated insn cache when exiting > back to guest > > vio->mmio_retry is being se

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Volodymyr Babchuk
Hi Julien, On 05.12.17 16:58, Julien Grall wrote: Hi Oleksandr, On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Volodymyr Babchuk Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existing use in PSCI code, but TEE mediator will need

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Julien Grall
On 05/12/17 17:08, Volodymyr Babchuk wrote: Hi Julien, On 05.12.17 16:58, Julien Grall wrote: Hi Oleksandr, On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Volodymyr Babchuk Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existi

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Oleksandr Tyshchenko
On Tue, Dec 5, 2017 at 7:08 PM, Volodymyr Babchuk wrote: > Hi Julien, Hi Julien, Volodymyr. > > On 05.12.17 16:58, Julien Grall wrote: >> >> Hi Oleksandr, >> >> On 09/11/17 17:10, Oleksandr Tyshchenko wrote: >>> >>> From: Volodymyr Babchuk >>> >>> Existing SMC wrapper call_smc() allows only 4 pa

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Volodymyr Babchuk wrote: > Hi Stefano, > > On Mon, Dec 04, 2017 at 06:30:13PM -0800, Stefano Stabellini wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > > > From: Volodymyr Babchuk > > > > > > Existing SMC wrapper call_smc() allows only 4 parameters and > > > retu

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 17:44, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 05 December 2017 16:14 >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -2109,20 +2109,22 @@ static int _hvm_emulate_one(struct hvm_e >> >> vio->mmio_retry = 0; >> >> -

[Xen-devel] [OSSTEST PATCH] sg-report-host-history: make link to host examination results

2017-12-05 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-report-host-history | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sg-report-host-history b/sg-report-host-history index e86e03b..19a86ab 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -149,6 +149,8 @@ sub reporthost ($) { $title=

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 17:19 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH] x86/HVM: don't retain emulated insn cache when > exiting back to guest

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-12-05 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] linux-arm-xen branch, commit access, etc."): > let's create a /arm/linux.git tree on xenbits where both Julien and I > can push. The idea is that we'll try to use vanilla kernel releases but > we'll keep it around just in case we'll need special patches

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets"): > On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote: > > Is that why you're not just updating osstest to expect the new > > behaviour ? > > Yes, I think it's more sensible to r

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-12-05 Thread Julien Grall
Hi Ian, On 05/12/17 17:42, Ian Jackson wrote: Stefano Stabellini writes ("Re: [Xen-devel] linux-arm-xen branch, commit access, etc."): let's create a /arm/linux.git tree on xenbits where both Julien and I can push. The idea is that we'll try to use vanilla kernel releases but we'll keep it aro

[Xen-devel] [seabios test] 116858: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116858 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/116858/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not suc

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefano Stabellini > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index

[Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Ian Jackson
This drops the dependency on Stefano's personal git tree. The osstest output branch remains unmoved. CC: Stefano Stabellini CC: Julien Grall Signed-off-by: Ian Jackson --- ap-common | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ap-common b/ap-common index bc7c03c..457

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Dan Carpenter wrote: > bedata->ref can't be less than zero because it's unsigned. This affects > certain error paths in probe. We first set ->ref = -1 and then we set > it to a valid value later. > > Fixes: 219681909913 ("xen/pvcalls: connect to the backend") > Signed-off-by:

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Julien Grall
Hi Ian, On 05/12/17 18:28, Ian Jackson wrote: This drops the dependency on Stefano's personal git tree. The osstest output branch remains unmoved. CC: Stefano Stabellini CC: Julien Grall Signed-off-by: Ian Jackson Acked-by: Julien Grall Cheers, --- ap-common | 4 ++-- 1 file changed

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi Ian, > > On 05/12/17 18:28, Ian Jackson wrote: > > This drops the dependency on Stefano's personal git tree. > > The osstest output branch remains unmoved. > > > > CC: Stefano Stabellini > > CC: Julien Grall > > Signed-off-by: Ian Jackson > > Acked

[Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Julien Grall
Hi all, Even though it is an Arm failure, I have CCed x86 folks to get feedback on the approach. I have a WIP branch I could share if that interest people. Few months ago, we noticed an heisenbug on jobs run by osstest on the cubietrucks (see [1]). From the log, we figured out that the guest

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Ian Jackson
Stefano Stabellini writes ("Re: [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree"): > On Tue, 5 Dec 2017, Julien Grall wrote: > > Acked-by: Julien Grall > > Acked-by: Stefano Stabellini Thanks. This queued for my next osstest push, which I expect to do some time tomor

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-05 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Jan Beulich wrote: > >>> On 01.12.17 at 22:38, wrote: > > On Thu, 30 Nov 2017, Jan Beulich wrote: > >> Jann validly points out that with a caller bogusly requesting a zero- > >> element batch with non-zero high command bits (the ones used for > >> continuation encoding), the as

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Julien Grall
Hi Ian, On 05/12/17 18:41, Ian Jackson wrote: Stefano Stabellini writes ("Re: [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree"): On Tue, 5 Dec 2017, Julien Grall wrote: Acked-by: Julien Grall Acked-by: Stefano Stabellini Thanks. This queued for my next osstest

Re: [Xen-devel] [OSSTEST PATCH] Revert "make-flight etc.: drop arm64"

2017-12-05 Thread Julien Grall
On 05/12/17 18:59, Ian Jackson wrote: We have the laxtons back and they seem to be working. Finally! This reverts commit 329ef52c9866b2a8608a598836b7d5813de1e979. > Signed-off-by: Ian Jackson FWIW: Acked-by: Julien Grall Cheers, --- make-flight | 2 +- make-hosts-flight |

[Xen-devel] [OSSTEST PATCH] Revert "make-flight etc.: drop arm64"

2017-12-05 Thread Ian Jackson
We have the laxtons back and they seem to be working. This reverts commit 329ef52c9866b2a8608a598836b7d5813de1e979. Signed-off-by: Ian Jackson --- make-flight | 2 +- make-hosts-flight | 2 +- mfi-common| 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mak

[Xen-devel] [xen-unstable-smoke test] 116877: tolerable all pass - PUSHED

2017-12-05 Thread osstest service owner
flight 116877 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/116877/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > >> Another question is second_max_freq. As I understand, it is highest > >> non-turbo frequency calculated by framework to limit target frequency > >> when > >> turbo mode "is disabled". And Xen assumes that second_max_freq is > >> always P1 if turb

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-05 Thread Oleksandr Tyshchenko
Hi Stefano On Tue, Dec 5, 2017 at 12:46 AM, Stefano Stabellini wrote: > On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: >> Hi, Stefano >> >> On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stabellini >> wrote: >> > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: >> >> From: Oleksandr Dmytryshyn >> >> >

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > Hi Stefano > > On Tue, Dec 5, 2017 at 12:46 AM, Stefano Stabellini > wrote: > > On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > >> Hi, Stefano > >> > >> On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stabellini > >> wrote: > >> > On Thu, 9 Nov 2017, O

Re: [Xen-devel] [RFC PATCH 22/31] xen/arm: Add Xen changes to SCPI protocol

2017-12-05 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Modify the direct ported SCPI Message Protocol driver to be > functional inside Xen. > > As SCPI Message protocol driver expects mailbox to be registed, > find and initialize mailbox before probing it. > > Include

Re: [Xen-devel] [RFC PATCH 27/31] cpufreq: hack: perf->states isn't a real guest handle on ARM

2017-12-05 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch is just a temp solution to highlight a problem which > should be resolved in a proper way. > > set_px_pminfo() is intended to be called from platform hypercall > where "perf" argument was entirely filled

Re: [Xen-devel] [RFC PATCH 22/31] xen/arm: Add Xen changes to SCPI protocol

2017-12-05 Thread Julien Grall
On 05/12/2017 21:20, Stefano Stabellini wrote: On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Modify the direct ported SCPI Message Protocol driver to be functional inside Xen. As SCPI Message protocol driver expects mailbox to be registed, find and initialize ma

Re: [Xen-devel] [RFC PATCH 29/31] xen/arm: Introduce CPUFreq Interface component

2017-12-05 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch adds an interface component which performs following steps: > 1. Initialize everything needed SCPI based CPUFreq driver to be functional >(SCPI Message protocol, mailbox to communicate with SCP, etc).

Re: [Xen-devel] [RFC PATCH 00/31] CPUFreq on ARM

2017-12-05 Thread Stefano Stabellini
Hi Oleksandr, I just wanted to tell you that the patch series is very well organized and the patches very nicely split. Thank you! - Stefano On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Hi, all. > > The purpose of this RFC patch series is to add CPUFreq s

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi all, > > Even though it is an Arm failure, I have CCed x86 folks to get feedback on the > approach. I have a WIP branch I could share if that interest people. > > Few months ago, we noticed an heisenbug on jobs run by osstest on the > cubietrucks (see

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Julien Grall
On 05/12/2017 22:35, Stefano Stabellini wrote: On Tue, 5 Dec 2017, Julien Grall wrote: Hi all, Even though it is an Arm failure, I have CCed x86 folks to get feedback on the approach. I have a WIP branch I could share if that interest people. Few months ago, we noticed an heisenbug on jobs r

Re: [Xen-devel] [RFC v3 4/4] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-12-05 Thread Goel, Sameer
On 12/5/2017 7:17 AM, Julien Grall wrote: > Hello, > > On 05/12/17 03:59, Sameer Goel wrote: >> This driver follows an approach similar to smmu driver. The intent here >> is to reuse as much Linux code as possible. >> - Glue code has been introduced in headers to bridge the API calls. >> - Calle

[Xen-devel] [linux-3.18 test] 116862: regressions - trouble: blocked/broken/fail/pass

2017-12-05 Thread osstest service owner
flight 116862 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/116862/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm broken build-armhf-xsm 5 host-build-

[Xen-devel] [xen-unstable test] 116857: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116857 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/116857/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 10 windows-install fail REGR. vs. 116744 Tests which are fa

Re: [Xen-devel] [PATCH for-next 01/16] xen/arm: raw_copy_to_guest_helper: Rename flush_dcache to flags

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > In a follow-up patch, it will be necessary to pass more flags to the > function. > > Rename flush_dcache to flags and introduce a define to tell whether the > cache needs to be flushed after the copy. > > Signed-off-by: Julien Grall Reviewed-by: Stefan

Re: [Xen-devel] [PATCH for-next 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > All the helpers within arch/arm/guestcopy.c are doing the same things: > copy data from/to the guest. > > At the moment, the logic is duplicated in each helpers making more > difficult to implement new variant. > > The first step for the consolidation is

  1   2   >