Re: compat code lacks support for __attribute__

2023-06-16 Thread Jan Beulich
On 16.06.2023 12:22, Olaf Hering wrote: > Fri, 16 Jun 2023 12:07:20 +0200 Jan Beulich : > >> ... you're removing the line that's actually verifying this is the case. > > Yeah, because it disappeared. I think the other approach is to teach > the python tool about __attribute__(()). > > Let me kno

Re: compat code lacks support for __attribute__

2023-06-16 Thread Olaf Hering
Fri, 16 Jun 2023 12:07:20 +0200 Jan Beulich : > ... you're removing the line that's actually verifying this is the case. Yeah, because it disappeared. I think the other approach is to teach the python tool about __attribute__(()). Let me know which way is preferred. Olaf pgpghOyGFRHEO.pgp De

Re: compat code lacks support for __attribute__

2023-06-16 Thread Jan Beulich
On 16.06.2023 11:51, Olaf Hering wrote: > Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich : > >> However, if you're after adding packed attributes, and if you're >> meaning to only communicate between Xen and the tool stack, then >> the requirement above doesn't exist. Yet then I would also wonder >>

Re: compat code lacks support for __attribute__

2023-06-16 Thread Olaf Hering
Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich : > However, if you're after adding packed attributes, and if you're > meaning to only communicate between Xen and the tool stack, then > the requirement above doesn't exist. Yet then I would also wonder > whether you need any compat translation in the f

Re: compat code lacks support for __attribute__

2023-06-14 Thread Jan Beulich
On 14.06.2023 12:08, Olaf Hering wrote: > Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich : > >> So perhaps we could arrange for your additions to be excluded >> from the compat translation machinery? > > Is there maybe a place for headers which are not public, > but which are visible for tools/ and

Re: compat code lacks support for __attribute__

2023-06-14 Thread Olaf Hering
Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich : > So perhaps we could arrange for your additions to be excluded > from the compat translation machinery? Is there maybe a place for headers which are not public, but which are visible for tools/ and xen/? I think the trace functionality would be a can

Re: compat code lacks support for __attribute__

2023-06-14 Thread Jan Beulich
On 14.06.2023 10:43, Olaf Hering wrote: > I would like to share code between the hypervisor and xenalyze, so that > every definition comes from a single place and is not duplicated in xen > and xenalyze. This works as long as simple constructs like struct x {}; > are used. Depending on the data to

compat code lacks support for __attribute__

2023-06-14 Thread Olaf Hering
I would like to share code between the hypervisor and xenalyze, so that every definition comes from a single place and is not duplicated in xen and xenalyze. This works as long as simple constructs like struct x {}; are used. Depending on the data to be stored into the trace buffer, having support