On 16.06.2023 11:51, Olaf Hering wrote: > Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich <jbeul...@suse.com>: > >> However, if you're after adding packed attributes, and if you're >> meaning to only communicate between Xen and the tool stack, then >> the requirement above doesn't exist. Yet then I would also wonder >> whether you need any compat translation in the first place. Those >> packed structures would better be arch-/bitness-agnostic, wouldn't >> they? So perhaps we could arrange for your additions to be excluded >> from the compat translation machinery? > > The change below works for me. I wonder if any special compat handling > for t_buf and t_rec is required. To me it looks like only uint32_t is > used, which will most likely cause no unexpected alignment issues.
No special handling is needed, indeed, but ... > --- a/xen/common/trace.c > +++ b/xen/common/trace.c > @@ -34,15 +34,6 @@ > #include <asm/atomic.h> > #include <public/sysctl.h> > > -#ifdef CONFIG_COMPAT > -#include <compat/trace.h> > -#define xen_t_buf t_buf > -CHECK_t_buf; ... you're removing the line that's actually verifying this is the case. Jan
