Re: [Xen-devel] [PATCH v9 08/23] x86emul: support AVX512PF insns

2019-07-04 Thread Andrew Cooper
On 04/07/2019 15:50, Jan Beulich wrote: > On 04.07.2019 16:44, Andrew Cooper wrote: >> On 01/07/2019 12:20, Jan Beulich wrote: >>> +/* Clear untouched parts of the mask value. */ >>> +n = 1 << (4 - ((b & 1) | evex.w)); >>> +op_mask &= (1 << n) - 1; >>> + >>> +for ( i

Re: [Xen-devel] [PATCH v9 08/23] x86emul: support AVX512PF insns

2019-07-04 Thread Jan Beulich
On 04.07.2019 16:44, Andrew Cooper wrote: > On 01/07/2019 12:20, Jan Beulich wrote: >> +/* Clear untouched parts of the mask value. */ >> +n = 1 << (4 - ((b & 1) | evex.w)); >> +op_mask &= (1 << n) - 1; >> + >> +for ( i = 0; rc == X86EMUL_OKAY && op_mask; ++i ) >> +

Re: [Xen-devel] [PATCH v9 08/23] x86emul: support AVX512PF insns

2019-07-04 Thread Andrew Cooper
On 01/07/2019 12:20, Jan Beulich wrote: > +/* Clear untouched parts of the mask value. */ > +n = 1 << (4 - ((b & 1) | evex.w)); > +op_mask &= (1 << n) - 1; > + > +for ( i = 0; rc == X86EMUL_OKAY && op_mask; ++i ) > +{ > +signed long idx = b & 1 ?