Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-26 Thread Viktor Mitin
Hi Jan, All, On Thu, Jul 18, 2019 at 4:38 PM Jan Beulich wrote: > >> But you're actively breaking Xen style here (and below). > > > > I don't see any mention of style restrictions regarding this in > > CODING_STYLE. If there is, I would prefer changing that so we can > > automate style checks wh

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:52 AM Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 7:37 AM Jan Beulich wrote: > > > > On 18.07.2019 15:16, Tamas K Lengyel wrote: > > > On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: > > >> > > >> On 18.07.2019 14:59, Tamas K Lengyel wrote: > > >>> On Thu, Jul

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:37 AM Jan Beulich wrote: > > On 18.07.2019 15:16, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: > >> > >> On 18.07.2019 14:59, Tamas K Lengyel wrote: > >>> On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: > > On 17.07.2019 21:

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:16, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: >> >> On 18.07.2019 14:59, Tamas K Lengyel wrote: >>> On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: On 17.07.2019 21:33, Tamas K Lengyel wrote: > @@ -136,8 +137,8 @@ static inline b

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: > > On 18.07.2019 14:59, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: > >> > >> On 17.07.2019 21:33, Tamas K Lengyel wrote: > >>> @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) > >>>

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Jan Beulich
On 18.07.2019 14:59, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: >> >> On 17.07.2019 21:33, Tamas K Lengyel wrote: >>> @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) >>>cpu_relax(); >>>nx = x + (1 | PGT_locked);

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: > > On 17.07.2019 21:33, Tamas K Lengyel wrote: > > @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) > > cpu_relax(); > > nx = x + (1 | PGT_locked); > > if ( !(x & PGT_validated) || > > -

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Jan Beulich
On 17.07.2019 21:33, Tamas K Lengyel wrote: > @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) > cpu_relax(); > nx = x + (1 | PGT_locked); > if ( !(x & PGT_validated) || > - !(x & PGT_count_mask) || > - !(nx & PGT_co