Re: [PATCH v7 08/19] xen/riscv: introduce cmpxchg.h

2024-04-04 Thread Oleksii
On Thu, 2024-04-04 at 18:14 +0200, Jan Beulich wrote: > On 04.04.2024 18:04, Oleksii wrote: > > On Thu, 2024-04-04 at 17:01 +0200, Jan Beulich wrote: > > > On 03.04.2024 12:20, Oleksii Kurochko wrote: > > > Everything else okay-ish to me now, but I can't very well given > > > an > > > ack for > > >

Re: [PATCH v7 08/19] xen/riscv: introduce cmpxchg.h

2024-04-04 Thread Jan Beulich
On 04.04.2024 18:04, Oleksii wrote: > On Thu, 2024-04-04 at 17:01 +0200, Jan Beulich wrote: >> On 03.04.2024 12:20, Oleksii Kurochko wrote: >> Everything else okay-ish to me now, but I can't very well given an >> ack for >> a patch depending on things that haven't been committed yet and may >> neve

Re: [PATCH v7 08/19] xen/riscv: introduce cmpxchg.h

2024-04-04 Thread Oleksii
On Thu, 2024-04-04 at 17:01 +0200, Jan Beulich wrote: > On 03.04.2024 12:20, Oleksii Kurochko wrote: > > +#define emulate_cmpxchg_1_2(ptr, old, new, lr_sfx, sc_sfx) \ > > +({ \ > > +    uint32_t *aligned_ptr; \ > > +    unsigned long alignment_mask = sizeof(*aligned_ptr) - > > sizeof(*(ptr)); \ > >

Re: [PATCH v7 08/19] xen/riscv: introduce cmpxchg.h

2024-04-04 Thread Jan Beulich
On 03.04.2024 12:20, Oleksii Kurochko wrote: > +#define emulate_cmpxchg_1_2(ptr, old, new, lr_sfx, sc_sfx) \ > +({ \ > +uint32_t *aligned_ptr; \ > +unsigned long alignment_mask = sizeof(*aligned_ptr) - sizeof(*(ptr)); \ > +uint8_t new_val_bit = \ > +((unsigned long)(ptr) & align