On Thu, 2024-04-04 at 18:14 +0200, Jan Beulich wrote: > On 04.04.2024 18:04, Oleksii wrote: > > On Thu, 2024-04-04 at 17:01 +0200, Jan Beulich wrote: > > > On 03.04.2024 12:20, Oleksii Kurochko wrote: > > > Everything else okay-ish to me now, but I can't very well given > > > an > > > ack for > > > a patch depending on things that haven't been committed yet and > > > may > > > never be. > > Except 3 dependency ( which should be dropped as nothing anymore is > > used now from this headers ): > > #include <asm/fence.h> > > #include <asm/io.h> > > #include <asm/system.h> > > > > It seems everything else doesn't depending on other things, does > > it? > > Didn't I see a STATIC_ASSERT_UNREACHABLE() somewhere? Sure, forgot about this macros. In this case, I think it would be better to return back:
extern void __bad_{xchg,...)(...); .... default: __bad_xchg(ptr, size), ret = 0; And do a follow-up patch when it will be committed. ~ Oleksii