Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-30 Thread Oleksii
Hi Shawn, On Wed, 2023-11-29 at 13:18 -0600, Shawn Anastasio wrote: > On 11/29/23 6:49 AM, Oleksii wrote: > > On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: > > > Hi Oleksii, > > > > > > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > > > > diff --git a/xen/arch/ppc/include/asm/irq.h >

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:49 AM, Oleksii wrote: > On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/irq.h >>> b/xen/arch/ppc/include/asm/irq.h >>> index 5c37d0cf25..49193fddff 100644 >>> --- a/xe

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Oleksii
On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: > Hi Oleksii, > > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > > diff --git a/xen/arch/ppc/include/asm/Makefile > > b/xen/arch/ppc/include/asm/Makefile > > index ece7fa66dd..df4c1ebb08 100644 > > --- a/xen/arch/ppc/include/asm/Makefile >

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Jan Beulich
On 28.11.2023 22:28, Shawn Anastasio wrote: > On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >> --- a/xen/arch/ppc/include/asm/irq.h >> +++ b/xen/arch/ppc/include/asm/irq.h >> @@ -3,7 +3,9 @@ >> #define __ASM_PPC_IRQ_H__ >> >> #include >> +#ifdef CONFIG_HAS_DEVICE_TREE > > I realize that you we

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 1:46 PM, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>> #define __ASM_PPC_IRQ_H__ >>> >>> #i

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > diff --git a/xen/arch/ppc/include/asm/Makefile > b/xen/arch/ppc/include/asm/Makefile > index ece7fa66dd..df4c1ebb08 100644 > --- a/xen/arch/ppc/include/asm/Makefile > +++ b/xen/arch/ppc/include/asm/Makefile > @@ -1,3 +1,4 @@ > # SPDX-Lic

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 20:46, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>>  #define __ASM_PPC_IRQ_H__ >>>   >>>  #include >>> +

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Oleksii
On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: > On 27.11.2023 15:13, Oleksii Kurochko wrote: > > Arm, PPC and RISC-V use the same device.h thereby device.h > > was moved to asm-generic. Arm's device.h was taken as a base with > > the following changes: > >  - #ifdef PCI related things. > >

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > Arm, PPC and RISC-V use the same device.h thereby device.h > was moved to asm-generic. Arm's device.h was taken as a base with > the following changes: > - #ifdef PCI related things. > - #ifdef ACPI related things. > - Rename #ifdef guards. > - Add