Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On Fri, Aug 05, 2022 at 11:54:06AM +0200, Jan Beulich wrote: > On 05.08.2022 11:51, Marek Marczykowski-Górecki wrote: > > On Fri, Aug 05, 2022 at 09:23:32AM +0200, Jan Beulich wrote: > >> On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > >>> +static struct xhci_trb evt_trb[DBC_TRB_RING_CAP];

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 05.08.2022 11:51, Marek Marczykowski-Górecki wrote: > On Fri, Aug 05, 2022 at 09:23:32AM +0200, Jan Beulich wrote: >> On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: >>> +static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; >>> +static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; >>> +static s

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On Fri, Aug 05, 2022 at 09:23:32AM +0200, Jan Beulich wrote: > On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > > +static uint64_t dbc_work_ring_size(const struct dbc_work_ring *ring) > > +{ > > +if ( ring->enq >= ring->deq ) > > +return ring->enq - ring->deq; > > + > > +ret

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > +static uint64_t dbc_work_ring_size(const struct dbc_work_ring *ring) > +{ > +if ( ring->enq >= ring->deq ) > +return ring->enq - ring->deq; > + > +return DBC_WORK_RING_CAP - ring->deq + ring->enq; > +} Doesn't unsigned int s

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 04.08.2022 16:34, Jan Beulich wrote: > On 04.08.2022 16:21, Jan Beulich wrote: >> On 04.08.2022 15:43, Marek Marczykowski-Górecki wrote: >>> On Thu, Aug 04, 2022 at 02:57:49PM +0200, Jan Beulich wrote: On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > +struct dbc { > +str

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 04.08.2022 16:28, Marek Marczykowski-Górecki wrote: > On Thu, Aug 04, 2022 at 04:21:01PM +0200, Jan Beulich wrote: >> On 04.08.2022 15:43, Marek Marczykowski-Górecki wrote: >>> I need to keep this structure somewhere DMA-reachable for the device (as >>> in - included in appropriate IOMMU context

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 04.08.2022 16:41, Marek Marczykowski-Górecki wrote: > On Thu, Aug 04, 2022 at 04:36:35PM +0200, Jan Beulich wrote: >> On 04.08.2022 16:28, Marek Marczykowski-Górecki wrote: >>> On Thu, Aug 04, 2022 at 04:21:01PM +0200, Jan Beulich wrote: L"Xen" looks sufficiently readable to me. We use this

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On Thu, Aug 04, 2022 at 04:36:35PM +0200, Jan Beulich wrote: > On 04.08.2022 16:28, Marek Marczykowski-Górecki wrote: > > On Thu, Aug 04, 2022 at 04:21:01PM +0200, Jan Beulich wrote: > >> L"Xen" looks sufficiently readable to me. We use this all over the > >> place in the EFI interfacing code. > >

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 04.08.2022 16:21, Jan Beulich wrote: > On 04.08.2022 15:43, Marek Marczykowski-Górecki wrote: >> On Thu, Aug 04, 2022 at 02:57:49PM +0200, Jan Beulich wrote: >>> On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: +struct dbc { +struct dbc_reg __iomem *dbc_reg; +struct

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On Thu, Aug 04, 2022 at 04:21:01PM +0200, Jan Beulich wrote: > On 04.08.2022 15:43, Marek Marczykowski-Górecki wrote: > > I need to keep this structure somewhere DMA-reachable for the device (as > > in - included in appropriate IOMMU context). Patch 8/10 is doing it. And > > also, patch 8/10 is put

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 04.08.2022 15:43, Marek Marczykowski-Górecki wrote: > On Thu, Aug 04, 2022 at 02:57:49PM +0200, Jan Beulich wrote: >> On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: >>> +struct dbc { >>> +struct dbc_reg __iomem *dbc_reg; >>> +struct xhci_dbc_ctx *dbc_ctx; >>> +struct xhci_ers

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On Thu, Aug 04, 2022 at 02:57:49PM +0200, Jan Beulich wrote: > On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > > +/* Defines the size in bytes of TRB rings as 2^DBC_TRB_RING_ORDER * 4096 */ > > +#ifndef DBC_TRB_RING_ORDER > > +#define DBC_TRB_RING_ORDER 4 > > +#endif > > +#define DBC_TRB_R

Re: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > +/* Defines the size in bytes of TRB rings as 2^DBC_TRB_RING_ORDER * 4096 */ > +#ifndef DBC_TRB_RING_ORDER > +#define DBC_TRB_RING_ORDER 4 > +#endif > +#define DBC_TRB_RING_CAP (DBC_TRB_PER_PAGE * (1 << DBC_TRB_RING_ORDER)) I have to admit t