On Thu, Aug 04, 2022 at 04:36:35PM +0200, Jan Beulich wrote: > On 04.08.2022 16:28, Marek Marczykowski-Górecki wrote: > > On Thu, Aug 04, 2022 at 04:21:01PM +0200, Jan Beulich wrote: > >> L"Xen" looks sufficiently readable to me. We use this all over the > >> place in the EFI interfacing code. > > > > Ok, I can try that. But given later adjustments, IIUC it will make the > > whole 50+ pages structure land in .data. Is that okay? > > No. I was actually expecting the piece of data we're talking about here > to land in .rodata, and hence be re-usable at the same address for all > devices. Hence my reference to string literals.
"all devices" - this driver supports only a single xhci debug console at a time. Anyway, as explained earlier, it would require reserving the whole page for it (there are no other xhci-related structures that can live in .rodata), which given your earlier comments about memory usage is probably worse. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab
signature.asc
Description: PGP signature
