Re: [PATCH v3] x86/hvm: Use constants for x86 modes

2024-12-19 Thread Teddy Astie
Le 19/12/2024 à 12:35, Andrew Cooper a écrit : > On 19/12/2024 10:46 am, Teddy Astie wrote: >> Hello, >> >> Le 18/12/2024 à 18:08, Andrew Cooper a écrit : >>> From: Teddy Astie >>> >>> In many places of x86 HVM code, constants integer are used to indicate in >>> what mode is >>> running the CPU (

Re: [PATCH v3] x86/hvm: Use constants for x86 modes

2024-12-19 Thread Andrew Cooper
On 19/12/2024 10:46 am, Teddy Astie wrote: > Hello, > > Le 18/12/2024 à 18:08, Andrew Cooper a écrit : >> From: Teddy Astie >> >> In many places of x86 HVM code, constants integer are used to indicate in >> what mode is >> running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these >

Re: [PATCH v3] x86/hvm: Use constants for x86 modes

2024-12-19 Thread Teddy Astie
Hello, Le 18/12/2024 à 18:08, Andrew Cooper a écrit : > From: Teddy Astie > > In many places of x86 HVM code, constants integer are used to indicate in > what mode is > running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these > constants are > are written directly as integer whic

Re: [PATCH v3] x86/hvm: Use constants for x86 modes

2024-12-19 Thread Jan Beulich
On 18.12.2024 18:08, Andrew Cooper wrote: > @@ -2952,11 +2954,11 @@ static const char *guest_x86_mode_to_str(int mode) > { > switch ( mode ) > { > -case 0: return "Real"; > -case 1: return "v86"; > -case 2: return "16bit"; > -case 4: return "32bit"; > -case 8: re