On 19/12/2024 10:46 am, Teddy Astie wrote: > Hello, > > Le 18/12/2024 à 18:08, Andrew Cooper a écrit : >> From: Teddy Astie <teddy.as...@vates.tech> >> >> In many places of x86 HVM code, constants integer are used to indicate in >> what mode is >> running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these >> constants are >> are written directly as integer which hides the actual meaning of these >> modes. >> >> This patch introduces X86_MODE_* macros and replace those occurences with it. >> >> Signed-off-by: Teddy Astie <teddy.as...@vates.tech> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Acked-by: Teddy Astie <teddy.as...@vates.tech>
Thanks, but as you're not a maintainer of this code, Ack doesn't carry any weight. Reviewed-by OTOH would, if you're happy with that adjustment? ~Andrew
