Re: [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-20 Thread Shawn Anastasio
Hi Jan, On 12/20/23 5:09 AM, Jan Beulich wrote: > On 15.12.2023 03:43, Shawn Anastasio wrote: >> Introduce setup.h to asm-generic based off of ARM's to define all >> stubs necessary to compile bootfdt.c >> >> Signed-off-by: Shawn Anastasio >> --- >> xen/arch/ppc/include/asm/Makefile | 1 + >>

Re: [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-20 Thread Jan Beulich
On 15.12.2023 03:43, Shawn Anastasio wrote: > Introduce setup.h to asm-generic based off of ARM's to define all > stubs necessary to compile bootfdt.c > > Signed-off-by: Shawn Anastasio > --- > xen/arch/ppc/include/asm/Makefile | 1 + > xen/arch/ppc/include/asm/setup.h | 6 -- > xen/include

Re: [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-19 Thread Jan Beulich
On 15.12.2023 03:43, Shawn Anastasio wrote: > Introduce setup.h to asm-generic based off of ARM's to define all > stubs necessary to compile bootfdt.c And - I'm sorry to ask - how's that "generic"? I'm also not convinced at all that a generic header can validly use BUG() in the way you propose. So