On 15.12.2023 03:43, Shawn Anastasio wrote: > Introduce setup.h to asm-generic based off of ARM's to define all > stubs necessary to compile bootfdt.c > > Signed-off-by: Shawn Anastasio <sanasta...@raptorengineering.com> > --- > xen/arch/ppc/include/asm/Makefile | 1 + > xen/arch/ppc/include/asm/setup.h | 6 -- > xen/include/asm-generic/setup.h | 148 ++++++++++++++++++++++++++++++ > 3 files changed, 149 insertions(+), 6 deletions(-) > delete mode 100644 xen/arch/ppc/include/asm/setup.h > create mode 100644 xen/include/asm-generic/setup.h > > diff --git a/xen/arch/ppc/include/asm/Makefile > b/xen/arch/ppc/include/asm/Makefile > index a711cfa856..7167661f86 100644 > --- a/xen/arch/ppc/include/asm/Makefile > +++ b/xen/arch/ppc/include/asm/Makefile > @@ -6,5 +6,6 @@ generic-y += iocap.h > generic-y += paging.h > generic-y += percpu.h > generic-y += random.h > +generic-y += setup.h > generic-y += static-shmem.h > generic-y += vm_event.h
Looking at patch 5, you undo this there. Why introduce it in the first place then? And why leave a stale (unused) file around there? Jan
