Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2025-01-03 Thread Denis Mukhin
On Wednesday, December 11th, 2024 at 7:19 AM, Roger Pau Monné wrote: > > > On Thu, Dec 05, 2024 at 08:41:39PM -0800, Denis Mukhin via B4 Relay wrote: > > > From: Denis Mukhin dmuk...@ford.com > > > > Print d->arch.emulation_flags on the console for better traceability while > > debugging in-hy

Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2025-01-03 Thread Denis Mukhin
On Tuesday, December 10th, 2024 at 5:30 AM, Jan Beulich wrote: > > > On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > > > Print d->arch.emulation_flags on the console for better traceability while > > debugging in-hypervisor hardware emulators. > > > Personally I disagree with such extr

Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2024-12-12 Thread Jan Beulich
On 12.12.2024 13:11, Roger Pau Monné wrote: > On Thu, Dec 12, 2024 at 12:53:45PM +0100, Jan Beulich wrote: >> On 11.12.2024 16:19, Roger Pau Monné wrote: >>> On Thu, Dec 05, 2024 at 08:41:39PM -0800, Denis Mukhin via B4 Relay wrote: --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c

Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2024-12-12 Thread Roger Pau Monné
On Thu, Dec 12, 2024 at 12:53:45PM +0100, Jan Beulich wrote: > On 11.12.2024 16:19, Roger Pau Monné wrote: > > On Thu, Dec 05, 2024 at 08:41:39PM -0800, Denis Mukhin via B4 Relay wrote: > >> --- a/xen/arch/x86/domain.c > >> +++ b/xen/arch/x86/domain.c > >> @@ -818,11 +818,15 @@ int arch_domain_crea

Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2024-12-12 Thread Jan Beulich
On 11.12.2024 16:19, Roger Pau Monné wrote: > On Thu, Dec 05, 2024 at 08:41:39PM -0800, Denis Mukhin via B4 Relay wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -818,11 +818,15 @@ int arch_domain_create(struct domain *d, >> >> if ( !emulation_flags_ok(d, emflags)

Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2024-12-11 Thread Roger Pau Monné
On Thu, Dec 05, 2024 at 08:41:39PM -0800, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > Print d->arch.emulation_flags on the console for better traceability while > debugging in-hypervisor hardware emulators. > > Signed-off-by: Denis Mukhin > --- > xen/arch/x86/domain.c | 8 ++-

Re: [PATCH v2 09/35] x86/domain: print emulation_flags

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > Print d->arch.emulation_flags on the console for better traceability while > debugging in-hypervisor hardware emulators. Personally I disagree with such extra printing. And that would in this case even apply if you used dprintk() or gdprintk(