On 12.12.2024 13:11, Roger Pau Monné wrote:
> On Thu, Dec 12, 2024 at 12:53:45PM +0100, Jan Beulich wrote:
>> On 11.12.2024 16:19, Roger Pau Monné wrote:
>>> On Thu, Dec 05, 2024 at 08:41:39PM -0800, Denis Mukhin via B4 Relay wrote:
>>>> --- a/xen/arch/x86/domain.c
>>>> +++ b/xen/arch/x86/domain.c
>>>> @@ -818,11 +818,15 @@ int arch_domain_create(struct domain *d,
>>>>
>>>> if ( !emulation_flags_ok(d, emflags) )
>>>> {
>>>> - printk(XENLOG_G_ERR "d%d: Xen does not allow %s domain creation "
>>>> + printk(XENLOG_G_ERR "d%d: Xen does not allow %s %sdomain creation
>>>> "
>>>
>>> gprintk(XENLOG_ERR, "...
>>>
>>> Might be more natural now that we have the macro (together with Jan's
>>> suggestion to use %pd (same below).
>>
>> Yet why would we want to log current here, as gprintk() does?
>
> Right - I've forgotten that gprintk already prepends %pd.
FTAOD: It's %pv and logging current, which isn't what is being logged here
(an incoming struct domain *).
Jan
