Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-13 Thread Shawn Anastasio
On Mon Jun 12, 2023 at 10:19 AM CDT, George Dunlap wrote: > Shawn, > > Again sorry that you've sort of bumped a hornet's nest here. > > Just to clarify, the situation as I understand it is: Hi George, No problem, and thank you for the detailed explanation. > HOWEVER, as Andrew says, there is no

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-12 Thread Julien Grall
Hi George, Thanks for the summary! A couple of comments below. On 12/06/2023 16:19, George Dunlap wrote: On Fri, Jun 9, 2023 at 5:07 PM Julien Grall wrote: Hi Shawn, On 09/06/2023 16:01, Shawn Anastasio wrote: On Fri Jun 9, 2023 at 5:12 AM CDT, Julien Grall wrote: Strictly speaking we can

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-12 Thread George Dunlap
On Fri, Jun 9, 2023 at 5:07 PM Julien Grall wrote: > Hi Shawn, > > On 09/06/2023 16:01, Shawn Anastasio wrote: > > On Fri Jun 9, 2023 at 5:12 AM CDT, Julien Grall wrote: > >> Strictly speaking we can refuse any code. That count for license as > >> well. Anyway, I didn't request a change here. I m

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Shawn Anastasio
On Fri Jun 9, 2023 at 11:07 AM CDT, Julien Grall wrote: > Thanks for the explanations. To clarify, are you saying that all the > files will be GPLv2+ or just some? My idea was to license any file where I expect there to derivations from existing code as GPLv2+, and fall back to GPLv2-only for new

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Julien Grall
Hi Shawn, On 09/06/2023 16:01, Shawn Anastasio wrote: On Fri Jun 9, 2023 at 5:12 AM CDT, Julien Grall wrote: Strictly speaking we can refuse any code. That count for license as well. Anyway, I didn't request a change here. I merely pointed out that any use of GPLv2+ should be justified because

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Shawn Anastasio
On Fri Jun 9, 2023 at 4:22 AM CDT, Jan Beulich wrote: > > xen/arch/ppc/Kconfig.debug | 5 + > > xen/arch/ppc/Makefile| 3 +- > > xen/arch/ppc/boot_of.c | 122 +++ > > xen/arch/ppc/configs/openpower_defconfig | 1 + > > x

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Shawn Anastasio
On Fri Jun 9, 2023 at 5:12 AM CDT, Julien Grall wrote: > Strictly speaking we can refuse any code. That count for license as > well. Anyway, I didn't request a change here. I merely pointed out that > any use of GPLv2+ should be justified because on Arm most of the people > don't pay attention o

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Julien Grall
Hi Andrew, On 09/06/2023 10:54, Andrew Cooper wrote: On 09/06/2023 10:46 am, Julien Grall wrote: On 09/06/2023 10:43, Andrew Cooper wrote: On 09/06/2023 10:38 am, Jan Beulich wrote: On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Andrew Cooper
On 09/06/2023 10:46 am, Julien Grall wrote: > On 09/06/2023 10:43, Andrew Cooper wrote: >> On 09/06/2023 10:38 am, Jan Beulich wrote: >>> On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/boot_of.c >> @@ -0,0

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Julien Grall
Hi Andrew, On 09/06/2023 10:43, Andrew Cooper wrote: On 09/06/2023 10:38 am, Jan Beulich wrote: On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/arch/ppc/boot_of.c @@ -0,0 +1,122 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ B

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Andrew Cooper
On 09/06/2023 10:38 am, Jan Beulich wrote: > On 09.06.2023 11:29, Andrew Cooper wrote: >> On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/arch/ppc/boot_of.c @@ -0,0 +1,122 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>> By default we mean to use ... >>

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Julien Grall
Hi, On 09/06/2023 10:38, Jan Beulich wrote: On 09.06.2023 11:29, Andrew Cooper wrote: On 09/06/2023 10:22 am, Jan Beulich wrote: --- /dev/null +++ b/xen/arch/ppc/boot_of.c @@ -0,0 +1,122 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ By default we mean to use ... --- /dev/null +++ b/xe

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Jan Beulich
On 09.06.2023 11:29, Andrew Cooper wrote: > On 09/06/2023 10:22 am, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/arch/ppc/boot_of.c >>> @@ -0,0 +1,122 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> By default we mean to use ... >> >>> --- /dev/null >>> +++ b/xen/arch/ppc/early_pri

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Andrew Cooper
On 09/06/2023 10:22 am, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/boot_of.c >> @@ -0,0 +1,122 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ > By default we mean to use ... > >> --- /dev/null >> +++ b/xen/arch/ppc/early_printk.c >> @@ -0,0 +1,36 @@ >> +/* SPDX-License-Identi

Re: [PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-09 Thread Jan Beulich
On 07.06.2023 17:06, Shawn Anastasio wrote: > On typical Power VMs (e.g. QEMU's -M pseries), a variety of services > are provided by OpenFirmware, including an early serial console. > Implement the required interfaces to call into OpenFirmware and write > to the serial console. > > Since OpenFirmw