Re: [PATCH] livepatch-build-tools: fix misuse of script directory as work directory

2023-12-14 Thread Roger Pau Monné
On Thu, Dec 14, 2023 at 09:19:35AM +0100, Jan Beulich wrote: > On 13.12.2023 14:51, Roger Pau Monne wrote: > > --- a/livepatch-build > > +++ b/livepatch-build > > @@ -25,6 +25,7 @@ > > # script. > > > > SCRIPTDIR="$(readlink -f $(dirname $(type -p $0)))" > > +WORKDIR="$(readlink -f -- .)" > >

Re: [PATCH] livepatch-build-tools: fix misuse of script directory as work directory

2023-12-14 Thread Jan Beulich
On 13.12.2023 14:51, Roger Pau Monne wrote: > --- a/livepatch-build > +++ b/livepatch-build > @@ -25,6 +25,7 @@ > # script. > > SCRIPTDIR="$(readlink -f $(dirname $(type -p $0)))" > +WORKDIR="$(readlink -f -- .)" More for my own education than anything else: Isn't the (standard) pwd utility in

Re: [PATCH] livepatch-build-tools: fix misuse of script directory as work directory

2023-12-13 Thread Ross Lagerwall
On Wed, Dec 13, 2023 at 1:52 PM Roger Pau Monne wrote: > > It's incorrect to assume that the script directory will always match the > directory the script is executed from. Instead cache the directory at the > start of script execution in order to be able to get back to it if needed. > > Fixes: 6