Re: [PATCH] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Bertrand Marquis
Hi Jan, > On 20 May 2022, at 12:06, Jan Beulich wrote: > > On 20.05.2022 12:49, Bertrand Marquis wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c >> $(objtree)/include/generated/autoconf.h >> $(call if_changed,cppcheck_xml)

Re: [PATCH] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Julien Grall
Hi Bertrand, On 20/05/2022 11:49, Bertrand Marquis wrote: If cppcheck is not present, the following warning appears during build: which: no cppcheck in ([...]) /bin/sh: cppcheck: command not found Fix this by hiding the error output from which and only try to execute cppcheck --version if we ha

Re: [PATCH] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Jan Beulich
On 20.05.2022 12:49, Bertrand Marquis wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c > $(objtree)/include/generated/autoconf.h > $(call if_changed,cppcheck_xml) > > cppcheck-version: > -ifeq ($(shell which $(CPPCHECK)),) >