Hi Jan,
> On 20 May 2022, at 12:06, Jan Beulich <jbeul...@suse.com> wrote:
>
> On 20.05.2022 12:49, Bertrand Marquis wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c
>> $(objtree)/include/generated/autoconf.h
>> $(call if_changed,cppcheck_xml)
>>
>> cppcheck-version:
>> -ifeq ($(shell which $(CPPCHECK)),)
>> +ifeq ($(shell which $(CPPCHECK) 2> /dev/null),)
>> $(error Cannot find cppcheck executable: $(CPPCHECK))
>> -endif
>> +else
>> ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1)
>> $(error Please upgrade your cppcheck to version 2.7 or greater)
>> endif
>> +endif
>
> While I agree this will silence things, I still would prefer if you
> switched to $(if ...) inside the rule - there's no need to invoke the
> shell while parsing the makefile. Anything like this only needlessly
> slows down the build. Not by much, but it sums up.
I will submit a v2 to solve this properly.
Cheers
Bertrand
>
> Jan
>
