Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-21 Thread Anthony PERARD
On Tue, Aug 21, 2018 at 10:08:49AM +0100, Wei Liu wrote: > On Tue, Aug 07, 2018 at 03:40:17PM +0100, Anthony PERARD wrote: > > On Tue, Aug 07, 2018 at 04:18:21PM +0200, Roger Pau Monné wrote: > > > On Mon, Aug 06, 2018 at 06:20:50PM +0100, Anthony PERARD wrote: > > > > On Thu, Aug 02, 2018 at 05:50

Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-21 Thread Wei Liu
On Tue, Aug 07, 2018 at 03:40:17PM +0100, Anthony PERARD wrote: > On Tue, Aug 07, 2018 at 04:18:21PM +0200, Roger Pau Monné wrote: > > On Mon, Aug 06, 2018 at 06:20:50PM +0100, Anthony PERARD wrote: > > > On Thu, Aug 02, 2018 at 05:50:52PM +0200, Roger Pau Monné wrote: > > > > On Fri, Jul 27, 2018

Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-07 Thread Anthony PERARD
On Tue, Aug 07, 2018 at 04:18:21PM +0200, Roger Pau Monné wrote: > On Mon, Aug 06, 2018 at 06:20:50PM +0100, Anthony PERARD wrote: > > On Thu, Aug 02, 2018 at 05:50:52PM +0200, Roger Pau Monné wrote: > > > On Fri, Jul 27, 2018 at 03:06:13PM +0100, Anthony PERARD wrote: > > > Can you provide a comme

Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-07 Thread Roger Pau Monné
On Mon, Aug 06, 2018 at 06:20:50PM +0100, Anthony PERARD wrote: > On Thu, Aug 02, 2018 at 05:50:52PM +0200, Roger Pau Monné wrote: > > On Fri, Jul 27, 2018 at 03:06:13PM +0100, Anthony PERARD wrote: > > Can you provide a comment explaining how is this supposed to work? The > > current code is alrea

Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-06 Thread Anthony PERARD
On Thu, Aug 02, 2018 at 05:50:52PM +0200, Roger Pau Monné wrote: > On Fri, Jul 27, 2018 at 03:06:13PM +0100, Anthony PERARD wrote: > Can you provide a comment explaining how is this supposed to work? The > current code is already quite convoluted IMO (maybe because I'm not > familiar with it), so I

Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:13PM +0100, Anthony PERARD wrote: > This is to prepare libxl_cdrom_insert to be able to send commands to > QEMU via the libxl__ev_qmp. The next patch is going to make use of it. > > Signed-off-by: Anthony PERARD > --- > tools/libxl/libxl_disk.c | 194 +++

[Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-07-27 Thread Anthony PERARD
This is to prepare libxl_cdrom_insert to be able to send commands to QEMU via the libxl__ev_qmp. The next patch is going to make use of it. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_disk.c | 194 +++ 1 file changed, 137 insertions(+), 57 deletions(-)