On Mon, Aug 06, 2018 at 06:20:50PM +0100, Anthony PERARD wrote: > On Thu, Aug 02, 2018 at 05:50:52PM +0200, Roger Pau Monné wrote: > > On Fri, Jul 27, 2018 at 03:06:13PM +0100, Anthony PERARD wrote: > > Can you provide a comment explaining how is this supposed to work? The > > current code is already quite convoluted IMO (maybe because I'm not > > familiar with it), so I think a comment would help reviewers. > > Have you read the CODING_STYLE file? I think you'll find that the > section "ASYNCHRONOUS/LONG-RUNNING OPERATIONS" will give you some answer > you are looking for. I'm not sure I'm following it perfectly, but at > least partially.
Oh, I didn't mean comments about the async operations, but I would add a note to clarify that you first empty the CDROM and then you attach the specified image. Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
