Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread George Dunlap
On 10/9/19 3:28 PM, Jan Beulich wrote: > On 09.10.2019 16:14, George Dunlap wrote: >> On 10/9/19 11:23 AM, Jürgen Groß wrote: Regardless of the merits of the change Andy wants to see, it's not a one that should be made during a feature freeze. >>> >>> Indeed. So either we take this patch

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread Jan Beulich
On 09.10.2019 16:14, George Dunlap wrote: > On 10/9/19 11:23 AM, Jürgen Groß wrote: >>> Regardless of the merits of the change Andy wants to see, it's not a one >>> that should be made during a feature freeze. >> >> Indeed. So either we take this patch or we have to revert the patch(es) >> introduc

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread George Dunlap
On 10/9/19 11:23 AM, Jürgen Groß wrote: >> Regardless of the merits of the change Andy wants to see, it's not a one >> that should be made during a feature freeze. > > Indeed. So either we take this patch or we have to revert the patch(es) > introducing the regression. Actually, just chatting wit

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread Jürgen Groß
On 09.10.19 12:21, George Dunlap wrote: On 10/9/19 11:16 AM, Jan Beulich wrote: On 08.10.2019 18:38, Andrew Cooper wrote: On 08/10/2019 17:10, Jan Beulich wrote: From: Paul Durrant Now that xl.cfg has an option to explicitly enable IOMMU mappings for a domain, migration may be needlessly vet

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread George Dunlap
On 10/9/19 11:16 AM, Jan Beulich wrote: > On 08.10.2019 18:38, Andrew Cooper wrote: >> On 08/10/2019 17:10, Jan Beulich wrote: >>> From: Paul Durrant >>> >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >>> domain, migration may be needlessly vetoed due to the check of >

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread Jan Beulich
On 08.10.2019 18:38, Andrew Cooper wrote: > On 08/10/2019 17:10, Jan Beulich wrote: >> From: Paul Durrant >> >> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >> domain, migration may be needlessly vetoed due to the check of >> is_iommu_enabled() in paging_log_dirty_enable

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread George Dunlap
On 10/8/19 5:10 PM, Jan Beulich wrote: > From: Paul Durrant > > Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > domain, migration may be needlessly vetoed due to the check of > is_iommu_enabled() in paging_log_dirty_enable(). > There is actually no need to prevent logdir

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread Paul Durrant
On Wed, 9 Oct 2019 at 09:49, Jan Beulich wrote: > > On 08.10.2019 18:38, Andrew Cooper wrote: > > On 08/10/2019 17:10, Jan Beulich wrote: > >> From: Paul Durrant > >> > >> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > >> domain, migration may be needlessly vetoed due t

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-09 Thread Jan Beulich
On 08.10.2019 18:38, Andrew Cooper wrote: > On 08/10/2019 17:10, Jan Beulich wrote: >> From: Paul Durrant >> >> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >> domain, migration may be needlessly vetoed due to the check of >> is_iommu_enabled() in paging_log_dirty_enable

Re: [Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-08 Thread Andrew Cooper
On 08/10/2019 17:10, Jan Beulich wrote: > From: Paul Durrant > > Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > domain, migration may be needlessly vetoed due to the check of > is_iommu_enabled() in paging_log_dirty_enable(). > There is actually no need to prevent logdir

[Xen-devel] [PATCH v3] x86/mm: don't needlessly veto migration

2019-10-08 Thread Jan Beulich
From: Paul Durrant Now that xl.cfg has an option to explicitly enable IOMMU mappings for a domain, migration may be needlessly vetoed due to the check of is_iommu_enabled() in paging_log_dirty_enable(). There is actually no need to prevent logdirty from being enabled unless devices are assigned t