On 08/10/2019 17:10, Jan Beulich wrote: > From: Paul Durrant <paul.durr...@citrix.com> > > Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > domain, migration may be needlessly vetoed due to the check of > is_iommu_enabled() in paging_log_dirty_enable(). > There is actually no need to prevent logdirty from being enabled unless > devices are assigned to a domain. > > NOTE: While in the neighbourhood, the bool_t parameter type in > paging_log_dirty_enable() is replaced with a bool and the format > of the comment in assign_device() is fixed. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Release-acked-by: Juergen Gross <jgr...@suse.com>
Seriously FFS. Why am I having to repeat myself? What if any way unclear on the previous threads? NACK NACK NACK. Xen is, and has always been, the wrong place to have any logic, because IT DOESN'T HAVE ENOUGH INFORMATION TO MAKE THE DECISION CORRECTLY. The toolstack does. Therefore, the toolstack is the only level capable decide whether it is safe to migration/suspend/resume/checkpoint the VM. If I have to write the patches myself, I will, but this patch in this form is frankly unacceptable. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
