Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

> On 9 Dec 2019, at 11:02, Lars Kurth wrote: > > > > On 06/12/2019, 09:51, "Jan Beulich" > wrote: > >On 06.12.2019 00:41, Lars Kurth wrote: >> I propose to add the following section to code-review-guide.md >> >> >> ## Problematic Patch Reviews >> >> A t

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 06/12/2019, 09:51, "Jan Beulich" wrote: On 06.12.2019 00:41, Lars Kurth wrote: > I propose to add the following section to code-review-guide.md > > > ## Problematic Patch Reviews > > A typical waterfall software development process is sequential with the

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 06.12.2019 00:41, Lars Kurth wrote: > I propose to add the following section to code-review-guide.md > > > ## Problematic Patch Reviews > > A typical waterfall software development process is sequential with the > following  > steps: define requirements, analyse, design, code, test and d

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 28/11/2019, 12:12, "Rich Persaud" wrote: On Nov 28, 2019, at 05:12, Jan Beulich wrote: > > On 28.11.2019 01:54, Stefano Stabellini wrote: >>> On Thu, 26 Sep 2019, Lars Kurth wrote: >>> From: Lars Kurth >>> >>> This document highlights what reviewers such as m

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On Thu, 28 Nov 2019, Jan Beulich wrote: > On 28.11.2019 01:54, Stefano Stabellini wrote: > > On Thu, 26 Sep 2019, Lars Kurth wrote: > >> From: Lars Kurth > >> > >> This document highlights what reviewers such as maintainers and committers > >> look > >> for when reviewing code. It sets expectatio

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On Nov 28, 2019, at 05:12, Jan Beulich wrote: > > On 28.11.2019 01:54, Stefano Stabellini wrote: >>> On Thu, 26 Sep 2019, Lars Kurth wrote: >>> From: Lars Kurth >>> >>> This document highlights what reviewers such as maintainers and committers >>> look >>> for when reviewing code. It sets exp

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 28/11/2019, 07:37, "Jan Beulich" wrote: On 28.11.2019 14:06, Lars Kurth wrote: > I can certainly add something on the timing , along the lines of > * For complex series, consider the time it takes to do reviews (maybe with a guide of LOC per hour) and give reviewers enough time

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 28.11.2019 14:06, Lars Kurth wrote: > I can certainly add something on the timing , along the lines of > * For complex series, consider the time it takes to do reviews (maybe with a > guide of LOC per hour) and give reviewers enough time to > * For series with design issues or large questions,

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 28/11/2019, 04:09, "Jan Beulich" wrote: On 28.11.2019 01:54, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> From: Lars Kurth >> >> This document highlights what reviewers such as maintainers and committers look >> for when reviewing code. It

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 28.11.2019 01:54, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> From: Lars Kurth >> >> This document highlights what reviewers such as maintainers and committers >> look >> for when reviewing code. It sets expectations for code authors and provides >> a framework for co

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On Thu, 26 Sep 2019, Lars Kurth wrote: > From: Lars Kurth > > This document highlights what reviewers such as maintainers and committers > look > for when reviewing code. It sets expectations for code authors and provides > a framework for code reviewers. I think the document is missing a coupl

[Xen-devel] [PATCH v2 4/6] Add Code Review Guide

From: Lars Kurth This document highlights what reviewers such as maintainers and committers look for when reviewing code. It sets expectations for code authors and provides a framework for code reviewers. Signed-off-by: Lars Kurth --- Cc: minios-de...@lists.xenproject.org Cc: xen-...@lists.xenp