Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

2019-03-12 Thread Julien Grall
Hi Jan, On 12/03/2019 12:53, Jan Beulich wrote: On 12.03.19 at 11:23, wrote: >> On 3/12/19 9:35 AM, Jan Beulich wrote: >> On 11.03.19 at 19:19, wrote: On 11/03/2019 16:52, Jan Beulich wrote: > Correct coding style of asm() invocations. Coding style from where? Most of the

Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

2019-03-12 Thread Jan Beulich
>>> On 12.03.19 at 11:23, wrote: > On 3/12/19 9:35 AM, Jan Beulich wrote: > On 11.03.19 at 19:19, wrote: >>> On 11/03/2019 16:52, Jan Beulich wrote: Correct coding style of asm() invocations. >>> Coding style from where? Most of the Arm code does not contain space before >>> and after )

Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

2019-03-12 Thread Julien Grall
Hi Jan, On 3/12/19 9:35 AM, Jan Beulich wrote: On 11.03.19 at 19:19, wrote: On 11/03/2019 16:52, Jan Beulich wrote: Correct coding style of asm() invocations. Coding style from where? Most of the Arm code does not contain space before ( and after ) for asm invocations. I also can't find anyw

Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

2019-03-12 Thread Jan Beulich
>>> On 11.03.19 at 19:19, wrote: > On 11/03/2019 16:52, Jan Beulich wrote: >> Correct coding style of asm() invocations. > Coding style from where? Most of the Arm code does not contain space before ( > and after ) for asm invocations. I also can't find anywhere in CODING_STYLE > imposing this s

Re: [Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

2019-03-11 Thread Julien Grall
Hi Jan, On 11/03/2019 16:52, Jan Beulich wrote: Correct coding style of asm() invocations. Coding style from where? Most of the Arm code does not contain space before ( and after ) for asm invocations. I also can't find anywhere in CODING_STYLE imposing this style. So please remove this change

[Xen-devel] [PATCH 7/7] Arm/atomic: cosmetics

2019-03-11 Thread Jan Beulich
Correct coding style of asm() invocations. Drop redundant casts. Un-define no longer needed macros after use. Signed-off-by: Jan Beulich --- a/xen/include/asm-arm/atomic.h +++ b/xen/include/asm-arm/atomic.h @@ -9,29 +9,29 @@ static inline type name(const volatile type *addr) \ {