Hi Jan,
On 3/12/19 9:35 AM, Jan Beulich wrote:
On 11.03.19 at 19:19, <julien.gr...@arm.com> wrote:
On 11/03/2019 16:52, Jan Beulich wrote:
Correct coding style of asm() invocations.
Coding style from where? Most of the Arm code does not contain space before (
and after ) for asm invocations. I also can't find anywhere in CODING_STYLE
imposing this style. So please remove this change.
"asm" is a keyword just like "if" or "while", so the general "White space"
section is as applicable here. I can split the change if this part is
controversial, but if you want me to drop the change, then an Arm
specific annex to ./CODING_STYLE is going to be needed.
Strictly speaking, the section you refer mentions space between
"keywords" and "conditions". So I don't feel the section applies for
"asm volatile".
For Arm, I would still prefer to keep without space as we have most of
the code following that.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
