Re: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

2019-06-21 Thread Jan Beulich
>>> On 19.06.19 at 22:11, wrote: > * Drop .gnu.warning. Xen, not being a library, has no need for >__attribute__((__warning__("str"))) and isn't liable to ever gain such >annotations for link time warnings. > * Adjust the indentation of the start of ARM's .rodata section. > * Discard .

Re: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

2019-06-20 Thread Julien Grall
Hi Andrew, On 6/19/19 10:38 PM, Andrew Cooper wrote: On 19/06/2019 22:30, Julien Grall wrote: Hi, On 6/19/19 9:11 PM, Andrew Cooper wrote:   * Drop .gnu.warning.  Xen, not being a library, has no need for     __attribute__((__warning__("str"))) and isn't liable to ever gain such     annota

Re: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

2019-06-20 Thread Roger Pau Monné
On Wed, Jun 19, 2019 at 09:11:27PM +0100, Andrew Cooper wrote: > * Drop .gnu.warning. Xen, not being a library, has no need for >__attribute__((__warning__("str"))) and isn't liable to ever gain such >annotations for link time warnings. > * Adjust the indentation of the start of ARM's .r

Re: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

2019-06-19 Thread Andrew Cooper
On 19/06/2019 22:30, Julien Grall wrote: > Hi, > > On 6/19/19 9:11 PM, Andrew Cooper wrote: >>   * Drop .gnu.warning.  Xen, not being a library, has no need for >>     __attribute__((__warning__("str"))) and isn't liable to ever gain >> such >>     annotations for link time warnings. > > What if th

Re: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

2019-06-19 Thread Julien Grall
Hi, On 6/19/19 9:11 PM, Andrew Cooper wrote: * Drop .gnu.warning. Xen, not being a library, has no need for __attribute__((__warning__("str"))) and isn't liable to ever gain such annotations for link time warnings. What if this is introduced? How do we catch it? * Adjust the ind

[Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

2019-06-19 Thread Andrew Cooper
* Drop .gnu.warning. Xen, not being a library, has no need for __attribute__((__warning__("str"))) and isn't liable to ever gain such annotations for link time warnings. * Adjust the indentation of the start of ARM's .rodata section. * Discard .discard on ARM. Signed-off-by: Andrew Coope