Re: [Xen-devel] [PATCH 1/5] arm/alternatives: Fix apply_alternatives() API

2018-01-30 Thread Julien Grall
Hi, On 29/01/18 20:23, Stefano Stabellini wrote: On Mon, 29 Jan 2018, Andrew Cooper wrote: The !HAS_ALTERNATIVE case has bit-rotten and won't even compile. The x86 side of apply_alternatives() is void, while the ARM side returns int. However, the functions can't fail and no return values are c

Re: [Xen-devel] [PATCH 1/5] arm/alternatives: Fix apply_alternatives() API

2018-01-29 Thread Stefano Stabellini
On Mon, 29 Jan 2018, Andrew Cooper wrote: > The !HAS_ALTERNATIVE case has bit-rotten and won't even compile. > > The x86 side of apply_alternatives() is void, while the ARM side returns int. > However, the functions can't fail and no return values are checked. Switch > the ARM side to be void as

[Xen-devel] [PATCH 1/5] arm/alternatives: Fix apply_alternatives() API

2018-01-29 Thread Andrew Cooper
The !HAS_ALTERNATIVE case has bit-rotten and won't even compile. The x86 side of apply_alternatives() is void, while the ARM side returns int. However, the functions can't fail and no return values are checked. Switch the ARM side to be void as well. One observation is that __apply_alternatives_