Hi,
On 29/01/18 20:23, Stefano Stabellini wrote:
On Mon, 29 Jan 2018, Andrew Cooper wrote:
The !HAS_ALTERNATIVE case has bit-rotten and won't even compile.
The x86 side of apply_alternatives() is void, while the ARM side returns int.
However, the functions can't fail and no return values are checked. Switch
the ARM side to be void as well.
One observation is that __apply_alternatives_multi_stop() is only used at boot
time, so can become __init and its static data can become __initdata
Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Acked-by: Stefano Stabellini <sstabell...@kernel.org>
---
CC: Jan Beulich <jbeul...@suse.com>
CC: Stefano Stabellini <sstabell...@kernel.org>
CC: Julien Grall <julien.gr...@arm.com>
CC: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
CC: Ross Lagerwall <ross.lagerw...@citrix.com>
TODO: Drop the !HAS_ALTERNATIVE case on ARM?
Yeah, we could do. Julien, what do you think?
Sounds good. In that case, we should remove all the reference of
HAS_ALTERNATIVE in the code.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
