Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-27 Thread Andrew Cooper
On 26/03/2019 14:39, Jan Beulich wrote: On 26.03.19 at 15:23, wrote: >> IMO especially in the CPUID case it is desirable to explicitly specify >> the width of the data. Looking at nodes 0x8002 and following this >> should be rather clear (and I even think get_model_name() should be >> mod

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Jan Beulich
>>> On 26.03.19 at 15:47, wrote: > On 26/03/2019 15:39, Jan Beulich wrote: > On 26.03.19 at 15:23, wrote: >>> IMO especially in the CPUID case it is desirable to explicitly specify >>> the width of the data. Looking at nodes 0x8002 and following this >>> should be rather clear (and I even

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Juergen Gross
On 26/03/2019 15:39, Jan Beulich wrote: On 26.03.19 at 15:23, wrote: >> IMO especially in the CPUID case it is desirable to explicitly specify >> the width of the data. Looking at nodes 0x8002 and following this >> should be rather clear (and I even think get_model_name() should be >> mod

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Jan Beulich
>>> On 26.03.19 at 15:23, wrote: > IMO especially in the CPUID case it is desirable to explicitly specify > the width of the data. Looking at nodes 0x8002 and following this > should be rather clear (and I even think get_model_name() should be > modified to use a pointer to uint32_t instead of

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Juergen Gross
On 26/03/2019 15:07, Jan Beulich wrote: On 26.03.19 at 14:11, wrote: >> On 26/03/2019 11:52, Jan Beulich wrote: >> On 21.03.19 at 13:21, wrote: Also introduce constants for the vendor strings in CPUID leaf 0. Signed-off-by: Andrew Cooper >>> Reviewed-by: Jan Beulich >>>

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Jan Beulich
>>> On 26.03.19 at 14:11, wrote: > On 26/03/2019 11:52, Jan Beulich wrote: > On 21.03.19 at 13:21, wrote: >>> Also introduce constants for the vendor strings in CPUID leaf 0. >>> >>> Signed-off-by: Andrew Cooper >> Reviewed-by: Jan Beulich >> albeit I'd appreciate if this was committed toge

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Andrew Cooper
On 26/03/2019 11:52, Jan Beulich wrote: On 21.03.19 at 13:21, wrote: >> Also introduce constants for the vendor strings in CPUID leaf 0. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich > albeit I'd appreciate if this was committed together with an actual > user (other than the

Re: [Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-26 Thread Jan Beulich
>>> On 21.03.19 at 13:21, wrote: > Also introduce constants for the vendor strings in CPUID leaf 0. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich albeit I'd appreciate if this was committed together with an actual user (other than the testsuite one) of the new function, and despite

[Xen-devel] [PATCH 1/4] libx86: Introduce x86_cpuid_lookup_vendor()

2019-03-21 Thread Andrew Cooper
Also introduce constants for the vendor strings in CPUID leaf 0. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Sergey Dyasli --- tools/tests/cpu-policy/test-cpu-policy.c | 37 xen/include/asm-x86/x86-vendors.h| 2