>>> On 21.03.19 at 13:21, <andrew.coop...@citrix.com> wrote: > Also introduce constants for the vendor strings in CPUID leaf 0. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> albeit I'd appreciate if this was committed together with an actual user (other than the testsuite one) of the new function, and despite ... > --- a/xen/include/xen/lib/x86/cpuid.h > +++ b/xen/include/xen/lib/x86/cpuid.h > @@ -65,6 +65,12 @@ static inline void cpuid_count_leaf( > #undef BX_CON > #undef XCHG > > +/** > + * Given the vendor id from CPUID leaf 0, look up Xen's internal integer > + * vendor ID. Returns X86_VENDOR_UNKNOWN for any unknown vendor. > + */ > +unsigned int x86_cpuid_lookup_vendor(uint32_t ebx, uint32_t ecx, uint32_t > edx); ... the undesirable (imo; I think I know you think otherwise) use of fixed width types here. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel