Re: [Xen-devel] [PATCH] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Anthony PERARD
On Wed, Feb 05, 2020 at 10:50:46AM +, Durrant, Paul wrote: > > From: Anthony PERARD > > On Wed, Feb 05, 2020 at 09:37:24AM +, Paul Durrant wrote: > > > > > > -sdss->pvqemu.guest_domid = 0; > > > +sdss->pvqemu.guest_domid = INVALID_DOMID; > > > > How this works? INVALID_DOMID seems

Re: [Xen-devel] [PATCH] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Durrant, Paul
> -Original Message- > From: Anthony PERARD > Sent: 05 February 2020 10:47 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Ian Jackson > ; Wei Liu ; Roger Pau Monné > > Subject: Re: [PATCH] libxl: fix assertion failure in stub domain creation > > On Wed, Feb 05, 2020 at 09:37:

Re: [Xen-devel] [PATCH] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Anthony PERARD
On Wed, Feb 05, 2020 at 09:37:24AM +, Paul Durrant wrote: > An assertion in libxl__domain_make(): > > 'soft_reset || *domid == INVALID_DOMID' > > does not hold true for stub domain creation, where soft_reset is false > but the passed in domid == 0. This is easily fixed by changing the > initi

[Xen-devel] [PATCH] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Paul Durrant
An assertion in libxl__domain_make(): 'soft_reset || *domid == INVALID_DOMID' does not hold true for stub domain creation, where soft_reset is false but the passed in domid == 0. This is easily fixed by changing the initializer in libxl__spawn_stub_dm(). Fixes: 75259239d85d ("libxl_create: make