On Wed, Feb 05, 2020 at 10:50:46AM +0000, Durrant, Paul wrote: > > From: Anthony PERARD <anthony.per...@citrix.com> > > On Wed, Feb 05, 2020 at 09:37:24AM +0000, Paul Durrant wrote: > > > > > > - sdss->pvqemu.guest_domid = 0; > > > + sdss->pvqemu.guest_domid = INVALID_DOMID; > > > > How this works? INVALID_DOMID seems to be directly feed to > > xc_domain_create(), which is using XEN_DOMCTL_createdomain. > > But a comment in domctl.h for XEN_DOMCTL_createdomain read: > > NB. xen_domctl.domain is an IN/OUT parameter for this operation. > > If it is specified as zero, an id is auto-allocated and returned. > > So, is xc_domain_create going to create a new domain with > > domid==INVALID_DOMID? > > > > As it happens, no. That comment is wrong. It should read "If it is not set to > a valid value, an id is auto-allocated and returned".
Ok, then: Acked-by: Anthony PERARD <anthony.per...@citrix.com> Thanks, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
