Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-24 Thread Jan Beulich
On 25.06.2024 02:14, Stefano Stabellini wrote: > I do realize that some of the notifier pattern switches might want to > handle all parameters but Bugseng or anyone else looking for simple > improvements are not in the position to tell which ones they are. We > need to wait for a maintainer or expe

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-24 Thread Stefano Stabellini
On Sat, 22 Jun 2024, Julien Grall wrote: > On 21/06/2024 23:34, Stefano Stabellini wrote: > > > > > Yes, I also think this could be an opportunity to check the pattern > > > > > but no one has yet been identified to do this. > > > > > > > > I don't think I understand Julien's question and/or your

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-22 Thread Julien Grall
Hi Stefano, On 21/06/2024 23:34, Stefano Stabellini wrote: Yes, I also think this could be an opportunity to check the pattern but no one has yet been identified to do this. I don't think I understand Julien's question and/or your answer. Is the question whether someone has done an analysis t

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-21 Thread Stefano Stabellini
On Fri, 21 Jun 2024, Federico Serafini wrote: > On 21/06/24 03:13, Stefano Stabellini wrote: > > On Thu, 20 Jun 2024, Federico Serafini wrote: > > > On 19/06/24 13:17, Julien Grall wrote: > > > > Hi Federico, > > > > > > > > On 19/06/2024 10:29, Federico Serafini wrote: > > > > > MISRA C Rule 16.4

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-21 Thread Federico Serafini
On 21/06/24 03:13, Stefano Stabellini wrote: On Thu, 20 Jun 2024, Federico Serafini wrote: On 19/06/24 13:17, Julien Grall wrote: Hi Federico, On 19/06/2024 10:29, Federico Serafini wrote: MISRA C Rule 16.4 states that every `switch' statement shall have a `default' label" and a statement or

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-20 Thread Stefano Stabellini
On Thu, 20 Jun 2024, Federico Serafini wrote: > On 19/06/24 13:17, Julien Grall wrote: > > Hi Federico, > > > > On 19/06/2024 10:29, Federico Serafini wrote: > > > MISRA C Rule 16.4 states that every `switch' statement shall have a > > > `default' label" and a statement or a comment prior to the >

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-20 Thread Federico Serafini
On 19/06/24 13:17, Julien Grall wrote: Hi Federico, On 19/06/2024 10:29, Federico Serafini wrote: MISRA C Rule 16.4 states that every `switch' statement shall have a `default' label" and a statement or a comment prior to the terminating break statement. This patch addresses some violations of

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-19 Thread Jan Beulich
On 19.06.2024 13:21, Julien Grall wrote: > > > On 19/06/2024 12:17, Julien Grall wrote: >> Hi Federico, >> >> On 19/06/2024 10:29, Federico Serafini wrote: >>> MISRA C Rule 16.4 states that every `switch' statement shall have a >>> `default' label" and a statement or a comment prior to the >>> te

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-19 Thread Julien Grall
On 19/06/2024 12:17, Julien Grall wrote: Hi Federico, On 19/06/2024 10:29, Federico Serafini wrote: MISRA C Rule 16.4 states that every `switch' statement shall have a `default' label" and a statement or a comment prior to the terminating break statement. This patch addresses some violation

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-19 Thread Julien Grall
Hi Federico, On 19/06/2024 10:29, Federico Serafini wrote: MISRA C Rule 16.4 states that every `switch' statement shall have a `default' label" and a statement or a comment prior to the terminating break statement. This patch addresses some violations of the rule related to the "notifier patter

[XEN PATCH v2] xen: add explicit comment to identify notifier patterns

2024-06-19 Thread Federico Serafini
MISRA C Rule 16.4 states that every `switch' statement shall have a `default' label" and a statement or a comment prior to the terminating break statement. This patch addresses some violations of the rule related to the "notifier pattern": a frequently-used pattern whereby only a few values are ha