Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4

2023-08-09 Thread Stefano Stabellini
On Wed, 9 Aug 2023, Luca Fancellu wrote: > > On 9 Aug 2023, at 15:06, Jan Beulich wrote: > > > > On 09.08.2023 15:50, Luca Fancellu wrote: > >>> On 9 Aug 2023, at 12:02, Nicola Vetrini > >>> wrote: > >>> > >>> The variable 'saved_cmdline' can be defined static, > >>> as its only uses are withi

Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4

2023-08-09 Thread Luca Fancellu
> On 9 Aug 2023, at 15:06, Jan Beulich wrote: > > On 09.08.2023 15:50, Luca Fancellu wrote: >>> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: >>> >>> The variable 'saved_cmdline' can be defined static, >>> as its only uses are within the same file. This in turn avoids >>> violating Rule 8.4

Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4

2023-08-09 Thread Nicola Vetrini
On 09/08/2023 15:50, Luca Fancellu wrote: On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: The variable 'saved_cmdline' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. Signed-off-by: Nicola Vetrini ---

Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4

2023-08-09 Thread Jan Beulich
On 09.08.2023 15:50, Luca Fancellu wrote: >> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: >> >> The variable 'saved_cmdline' can be defined static, >> as its only uses are within the same file. This in turn avoids >> violating Rule 8.4 because no declaration is present. >> >> Signed-off-by: Nico

Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4

2023-08-09 Thread Luca Fancellu
> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: > > The variable 'saved_cmdline' can be defined static, > as its only uses are within the same file. This in turn avoids > violating Rule 8.4 because no declaration is present. > > Signed-off-by: Nicola Vetrini > --- > xen/common/kernel.c | 2

[XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4

2023-08-09 Thread Nicola Vetrini
The variable 'saved_cmdline' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. Signed-off-by: Nicola Vetrini --- xen/common/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/c