> On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetr...@bugseng.com> wrote:
>
> The variable 'saved_cmdline' can be defined static,
> as its only uses are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.
>
> Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com>
> ---
> xen/common/kernel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/kernel.c b/xen/common/kernel.c
> index fb919f3d9c..52aa287627 100644
> --- a/xen/common/kernel.c
> +++ b/xen/common/kernel.c
> @@ -28,7 +28,7 @@ CHECK_feature_info;
>
> enum system_state system_state = SYS_STATE_early_boot;
>
> -xen_commandline_t saved_cmdline;
> +static xen_commandline_t saved_cmdline;
I see this line was touched by fa97833ae18e4a42c0e5ba4e781173457b5d3397,
have you checked that making it static was not affecting anything else?
> static const char __initconst opt_builtin_cmdline[] = CONFIG_CMDLINE;
>
> static int assign_integer_param(const struct kernel_param *param, uint64_t
> val)
> --
> 2.34.1
>
>
