Re: [PATCH v5 2/4] x86/ucode: refactor xen-ucode to utilize getopt

2024-08-19 Thread Fouad Hilly
On Wed, Jul 24, 2024 at 5:55 PM Anthony PERARD wrote: > On Fri, Jul 12, 2024 at 02:07:47PM +0100, Fouad Hilly wrote: > > diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c > > index 390969db3d1c..8de82e5b8a10 100644 > > --- a/tools/misc/xen-ucode.c > > +++ b/tools/misc/xen-ucode.c > > @

Re: [PATCH v5 2/4] x86/ucode: refactor xen-ucode to utilize getopt

2024-07-24 Thread Anthony PERARD
On Fri, Jul 12, 2024 at 02:07:47PM +0100, Fouad Hilly wrote: > diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c > index 390969db3d1c..8de82e5b8a10 100644 > --- a/tools/misc/xen-ucode.c > +++ b/tools/misc/xen-ucode.c > @@ -71,12 +72,29 @@ static void show_curr_cpu(FILE *f) > } > }

Re: [PATCH v5 2/4] x86/ucode: refactor xen-ucode to utilize getopt

2024-07-23 Thread Fouad Hilly
On Tue, Jul 16, 2024 at 3:51 PM Jan Beulich wrote: > > On 12.07.2024 15:07, Fouad Hilly wrote: > > --- a/tools/misc/xen-ucode.c > > +++ b/tools/misc/xen-ucode.c > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > > > static xc_interface *xch; > > > > @@ -71,12 +7

Re: [PATCH v5 2/4] x86/ucode: refactor xen-ucode to utilize getopt

2024-07-16 Thread Jan Beulich
On 12.07.2024 15:07, Fouad Hilly wrote: > --- a/tools/misc/xen-ucode.c > +++ b/tools/misc/xen-ucode.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > static xc_interface *xch; > > @@ -71,12 +72,29 @@ static void show_curr_cpu(FILE *f) > } > } > > +static voi

[PATCH v5 2/4] x86/ucode: refactor xen-ucode to utilize getopt

2024-07-12 Thread Fouad Hilly
Use getopt_long() to handle command line arguments. Introduce ext_err for common exit with errors. Introducing usage() to handle usage\help messages in a common block. show_curr_cpu is printed to stdout only. Signed-off-by: Fouad Hilly --- [v5] 1- Update message description. 2- re-arrange static