Re: Ping: [PATCH v4 3/3] unzstd: make helper symbols static

2021-11-04 Thread Jan Beulich
On 30.06.2021 09:43, Jan Beulich wrote: > On 05.05.2021 19:35, Julien Grall wrote: >> >> >> On 29/04/2021 14:26, Jan Beulich wrote: >>> On 29.04.2021 13:27, Julien Grall wrote: On 21/04/2021 11:22, Jan Beulich wrote: > While for the original library's purposes these functions of course wan

Ping: [PATCH v4 3/3] unzstd: make helper symbols static

2021-06-30 Thread Jan Beulich
On 05.05.2021 19:35, Julien Grall wrote: > > > On 29/04/2021 14:26, Jan Beulich wrote: >> On 29.04.2021 13:27, Julien Grall wrote: >>> On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be externally exposed, we don't need

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-05-06 Thread Julien Grall
Hi Jan, On 06/05/2021 07:21, Jan Beulich wrote: On 05.05.2021 19:35, Julien Grall wrote: On 29/04/2021 14:26, Jan Beulich wrote: On 29.04.2021 13:27, Julien Grall wrote: On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be e

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-05-05 Thread Jan Beulich
On 05.05.2021 19:35, Julien Grall wrote: > > > On 29/04/2021 14:26, Jan Beulich wrote: >> On 29.04.2021 13:27, Julien Grall wrote: >>> On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be externally exposed, we don't need

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-05-05 Thread Julien Grall
On 29/04/2021 14:26, Jan Beulich wrote: On 29.04.2021 13:27, Julien Grall wrote: On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be externally exposed, we don't need this, and we also don't want this both to prevent unintend

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-04-29 Thread Jan Beulich
On 29.04.2021 13:27, Julien Grall wrote: > On 21/04/2021 11:22, Jan Beulich wrote: >> While for the original library's purposes these functions of course want >> to be externally exposed, we don't need this, and we also don't want >> this both to prevent unintended use and to keep the name space ti

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-04-29 Thread Julien Grall
Hi Jan, On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be externally exposed, we don't need this, and we also don't want this both to prevent unintended use and to keep the name space tidy. (When functions have no callers at al

[PATCH v4 3/3] unzstd: make helper symbols static

2021-04-21 Thread Jan Beulich
While for the original library's purposes these functions of course want to be externally exposed, we don't need this, and we also don't want this both to prevent unintended use and to keep the name space tidy. (When functions have no callers at all, wrap them with a suitable #ifdef.) This has the