Hi Jan, On 21/04/2021 11:22, Jan Beulich wrote:
While for the original library's purposes these functions of course want to be externally exposed, we don't need this, and we also don't want this both to prevent unintended use and to keep the name space tidy. (When functions have no callers at all, wrap them with a suitable #ifdef.) This has the added benefit of reducing the resulting binary size - while this is all .init code, it's still desirable to not carry dead code.
So I understand the desire to keep the code close to Linux and removing the dead code. However I am still not convinced that the approach taken is actually worth the amount of memory saved.
How much memory are we talking about here? Cheers, -- Julien Grall
