Re: [PATCH v4] vpci: Add resizable bar support

2025-01-09 Thread Jan Beulich
On 10.01.2025 08:10, Chen, Jiqian wrote: > On 2025/1/7 18:06, Jan Beulich wrote: >> On 19.12.2024 06:21, Jiqian Chen wrote: >>> +#define PCI_REBAR_CAP(n) (4 + 8 * (n)) /* capability register >>> */ >>> +#define PCI_REBAR_CAP_SHIFT 4 /* shift for >>> suppor

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-09 Thread Chen, Jiqian
On 2025/1/7 18:06, Jan Beulich wrote: > On 19.12.2024 06:21, Jiqian Chen wrote: >> --- /dev/null >> +++ b/xen/drivers/vpci/rebar.c >> @@ -0,0 +1,131 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2024 Advanced Micro Devices, Inc. All Rights Reserved. >> + * >> + * Au

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-07 Thread Roger Pau Monné
On Wed, Jan 08, 2025 at 08:19:55AM +0100, Jan Beulich wrote: > On 07.01.2025 19:19, Roger Pau Monné wrote: > > On Tue, Jan 07, 2025 at 04:58:07PM +0100, Jan Beulich wrote: > >> On 07.01.2025 15:38, Roger Pau Monné wrote: > >>> On Tue, Jan 07, 2025 at 11:06:33AM +0100, Jan Beulich wrote: > On 1

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-07 Thread Jan Beulich
On 07.01.2025 19:19, Roger Pau Monné wrote: > On Tue, Jan 07, 2025 at 04:58:07PM +0100, Jan Beulich wrote: >> On 07.01.2025 15:38, Roger Pau Monné wrote: >>> On Tue, Jan 07, 2025 at 11:06:33AM +0100, Jan Beulich wrote: On 19.12.2024 06:21, Jiqian Chen wrote: > --- /dev/null > +++ b/xen

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-07 Thread Roger Pau Monné
On Tue, Jan 07, 2025 at 04:58:07PM +0100, Jan Beulich wrote: > On 07.01.2025 15:38, Roger Pau Monné wrote: > > On Tue, Jan 07, 2025 at 11:06:33AM +0100, Jan Beulich wrote: > >> On 19.12.2024 06:21, Jiqian Chen wrote: > >>> --- /dev/null > >>> +++ b/xen/drivers/vpci/rebar.c > >>> @@ -0,0 +1,131 @@ >

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-07 Thread Jan Beulich
On 07.01.2025 15:38, Roger Pau Monné wrote: > On Tue, Jan 07, 2025 at 11:06:33AM +0100, Jan Beulich wrote: >> On 19.12.2024 06:21, Jiqian Chen wrote: >>> --- /dev/null >>> +++ b/xen/drivers/vpci/rebar.c >>> @@ -0,0 +1,131 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +/* >>> + * Copyright

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-07 Thread Roger Pau Monné
On Tue, Jan 07, 2025 at 11:06:33AM +0100, Jan Beulich wrote: > On 19.12.2024 06:21, Jiqian Chen wrote: > > --- /dev/null > > +++ b/xen/drivers/vpci/rebar.c > > @@ -0,0 +1,131 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Copyright (C) 2024 Advanced Micro Devices, Inc. All Righ

Re: [PATCH v4] vpci: Add resizable bar support

2025-01-07 Thread Jan Beulich
On 19.12.2024 06:21, Jiqian Chen wrote: > --- /dev/null > +++ b/xen/drivers/vpci/rebar.c > @@ -0,0 +1,131 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2024 Advanced Micro Devices, Inc. All Rights Reserved. > + * > + * Author: Jiqian Chen > + */ > + > +#include > +#i

[PATCH v4] vpci: Add resizable bar support

2024-12-18 Thread Jiqian Chen
Some devices, like discrete GPU of amd, support resizable bar capability, but vpci of Xen doesn't support this feature, so they fail to resize bars and then cause probing failure. According to PCIe spec, each bar that supports resizing has two registers, PCI_REBAR_CAP and PCI_REBAR_CTRL. So, add h