On 10.01.2025 08:10, Chen, Jiqian wrote: > On 2025/1/7 18:06, Jan Beulich wrote: >> On 19.12.2024 06:21, Jiqian Chen wrote: >>> +#define PCI_REBAR_CAP(n) (4 + 8 * (n)) /* capability register >>> */ >>> +#define PCI_REBAR_CAP_SHIFT 4 /* shift for >>> supported BAR sizes */ >>> +#define PCI_REBAR_CTRL(n) (8 + 8 * (n)) /* control register */ >> >> Something's odd with the padding here. Please be consistent with the use >> of whitespace (ought to be only hard tabs here afaict). > Sorry, I don't understand how to modify it specifically.
You surely have noticed that in two of the three quoted lines there are blanks immediately followed by tabs in the padding. This can hardly ever be correct. (The overall goal wants to be that "same level" definitions are column-wise properly aligned with one another. While nested ones, like you have it for PCI_REBAR_CAP_SHIFT, are properly identified as being nested. You want to check with other parts of the file if in doubt.) Jan
