Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-05-20 Thread Bertrand Marquis
Hi Julien, > On 20 May 2022, at 10:56, Julien Grall wrote: > > Hi Bertrand, > > Since this patch has been committed, I get the following message for on every > build (make -C xen): > > which: no cppcheck in ([...]) > /bin/sh: cppcheck: command not found > > I wasn't expecting the build syste

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-05-20 Thread Julien Grall
Hi Bertrand, Since this patch has been committed, I get the following message for on every build (make -C xen): which: no cppcheck in ([...]) /bin/sh: cppcheck: command not found I wasn't expecting the build system to check every time. I think... On 26/04/2022 13:38, Bertrand Marquis wrote:

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-05-10 Thread Bertrand Marquis
Hi Julien, > On 10 May 2022, at 12:50, Julien Grall wrote: > > > > On 10/05/2022 12:49, Bertrand Marquis wrote: >> Hi > > Hi Bertrand, > >>> On 9 May 2022, at 19:22, Julien Grall wrote: >>> >>> Hi, >>> >>> On 26/04/2022 13:38, Bertrand Marquis wrote: diff --git a/xen/arch/arm/include

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-05-10 Thread Julien Grall
On 10/05/2022 12:49, Bertrand Marquis wrote: Hi Hi Bertrand, On 9 May 2022, at 19:22, Julien Grall wrote: Hi, On 26/04/2022 13:38, Bertrand Marquis wrote: diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 852b5f3c24..ef37cfa16f 100644 ---

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-05-10 Thread Bertrand Marquis
Hi > On 9 May 2022, at 19:22, Julien Grall wrote: > > Hi, > > On 26/04/2022 13:38, Bertrand Marquis wrote: >> diff --git a/xen/arch/arm/include/asm/processor.h >> b/xen/arch/arm/include/asm/processor.h >> index 852b5f3c24..ef37cfa16f 100644 >> --- a/xen/arch/arm/include/asm/processor.h >> +++

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-05-09 Thread Julien Grall
Hi, On 26/04/2022 13:38, Bertrand Marquis wrote: diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 852b5f3c24..ef37cfa16f 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -219,9 +219,11 @@

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-04-26 Thread Stefano Stabellini
On Tue, 26 Apr 2022, Bertrand Marquis wrote: > cppcheck can be used to check Xen code quality. > > To create a report do "make cppcheck" on a built tree adding any options > you added during the process you used to build xen (like CROSS_COMPILE > or XEN_TARGET_ARCH). This will generate an xml repo

[PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

2022-04-26 Thread Bertrand Marquis
cppcheck can be used to check Xen code quality. To create a report do "make cppcheck" on a built tree adding any options you added during the process you used to build xen (like CROSS_COMPILE or XEN_TARGET_ARCH). This will generate an xml report xen-cppcheck.xml. To create a html report do "make