Hi Julien, > On 10 May 2022, at 12:50, Julien Grall <jul...@xen.org> wrote: > > > > On 10/05/2022 12:49, Bertrand Marquis wrote: >> Hi > > Hi Bertrand, > >>> On 9 May 2022, at 19:22, Julien Grall <jul...@xen.org> wrote: >>> >>> Hi, >>> >>> On 26/04/2022 13:38, Bertrand Marquis wrote: >>>> diff --git a/xen/arch/arm/include/asm/processor.h >>>> b/xen/arch/arm/include/asm/processor.h >>>> index 852b5f3c24..ef37cfa16f 100644 >>>> --- a/xen/arch/arm/include/asm/processor.h >>>> +++ b/xen/arch/arm/include/asm/processor.h >>>> @@ -219,9 +219,11 @@ >>>> SCTLR_Axx_ELx_A | SCTLR_Axx_ELx_C |\ >>>> SCTLR_Axx_ELx_WXN | SCTLR_Axx_ELx_EE) >>>> +#ifndef CPPCHECK >>> >>> Can you add a comment explaining why you need this check? >> Sure, would the following be ok ? >> Cppcheck preprocessor is wrongly throwing the error here so disable this >> check for cppcheck runs > > That's fine with me. I think my ack is technically sufficient here and > Stefano tested the patch. > > So will do the modification and commit it in a bit.
Thanks a lot :-) Cheers Bertrand > > Cheers, > > -- > Julien Grall
