Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 14:33 +0100, Julien Grall wrote: > On 23/07/2024 14:27, oleksii.kuroc...@gmail.com wrote: > > Hello Julien, > > Hi Oleksii, > > > > On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > > > diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c > > > > index 7d09e781bf

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
On Mon, 2024-07-22 at 19:04 +0200, oleksii.kuroc...@gmail.com wrote: > On Mon, 2024-07-22 at 17:25 +0200, Jan Beulich wrote: > > On 22.07.2024 16:36, Oleksii wrote: > > > On Mon, 2024-07-22 at 14:42 +0200, Jan Beulich wrote: > > > > On 12.07.2024 18:22, Oleksii Kurochko wrote: > > > > > --- a/xen/a

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread Julien Grall
On 23/07/2024 14:27, oleksii.kuroc...@gmail.com wrote: Hello Julien, Hi Oleksii, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index 7d09e781bf..d69a174b5d 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -49,6 +49

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread Julien Grall
On 23/07/2024 13:58, oleksii.kuroc...@gmail.com wrote: Hi Julien, Hi Oleksii, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: +/* Fixmap slots */ +#define FIX_PMAP_BEGIN (0) /* Start of PMAP */ +#define FIX_PMAP_END (FIX_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of PMAP */ ... here i

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
Hello Julien, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c > > index 7d09e781bf..d69a174b5d 100644 > > --- a/xen/arch/riscv/mm.c > > +++ b/xen/arch/riscv/mm.c > > @@ -49,6 +49,9 @@ stage1_pgtbl_root[PAGETABLE_ENTRIES]; > >    pte

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
Hi Julien, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > +/* Fixmap slots */ > > +#define FIX_PMAP_BEGIN (0) /* Start of PMAP */ > > +#define FIX_PMAP_END (FIX_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of > > PMAP */ > > ... here is seems to be inclusive. Furthermore if you had 32-bit >

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-22 Thread oleksii . kurochko
On Mon, 2024-07-22 at 17:25 +0200, Jan Beulich wrote: > On 22.07.2024 16:36, Oleksii wrote: > > On Mon, 2024-07-22 at 14:42 +0200, Jan Beulich wrote: > > > On 12.07.2024 18:22, Oleksii Kurochko wrote: > > > > --- a/xen/arch/riscv/include/asm/config.h > > > > +++ b/xen/arch/riscv/include/asm/config.

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-22 Thread Jan Beulich
On 22.07.2024 16:36, Oleksii wrote: > On Mon, 2024-07-22 at 14:42 +0200, Jan Beulich wrote: >> On 12.07.2024 18:22, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/include/asm/config.h >>> +++ b/xen/arch/riscv/include/asm/config.h >>> @@ -74,11 +74,20 @@ >>>  #error "unsupported RV_STAGE1_MODE" >>

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-22 Thread Julien Grall
On 22/07/2024 15:31, Oleksii wrote: Hi Julien, Hi Oleksii, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: Hi Oleksii, On 12/07/2024 17:22, Oleksii Kurochko wrote: Introduce a function to set up fixmap mappings and L0 page table for fixmap. Additionally, defines were introduced

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-22 Thread Oleksii
On Mon, 2024-07-22 at 14:42 +0200, Jan Beulich wrote: > On 12.07.2024 18:22, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/config.h > > +++ b/xen/arch/riscv/include/asm/config.h > > @@ -74,11 +74,20 @@ > >  #error "unsupported RV_STAGE1_MODE" > >  #endif > >   > > +#define XEN_SIZE  

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-22 Thread Oleksii
Hi Julien, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > Hi Oleksii, > > On 12/07/2024 17:22, Oleksii Kurochko wrote: > > Introduce a function to set up fixmap mappings and L0 page > > table for fixmap. > > > > Additionally, defines were introduced in riscv/config.h to > > calculate t

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-22 Thread Jan Beulich
On 12.07.2024 18:22, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -74,11 +74,20 @@ > #error "unsupported RV_STAGE1_MODE" > #endif > > +#define XEN_SIZEMB(2) > +#define XEN_VIRT_END(XEN_VIRT_START

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-21 Thread Julien Grall
Hi Oleksii, On 12/07/2024 17:22, Oleksii Kurochko wrote: Introduce a function to set up fixmap mappings and L0 page table for fixmap. Additionally, defines were introduced in riscv/config.h to calculate the FIXMAP_BASE address. This involved introducing BOOT_FDT_VIRT_{START, SIZE} and XEN_SIZE,

[PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-12 Thread Oleksii Kurochko
Introduce a function to set up fixmap mappings and L0 page table for fixmap. Additionally, defines were introduced in riscv/config.h to calculate the FIXMAP_BASE address. This involved introducing BOOT_FDT_VIRT_{START, SIZE} and XEN_SIZE, XEN_VIRT_END. Also, the check of Xen size was updated in t