Re: [PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-19 Thread Marek Marczykowski-Górecki
On Thu, Aug 19, 2021 at 06:01:31PM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Aug 19, 2021 at 05:57:21PM +0200, Jan Beulich wrote: > > On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > > > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > > > *uart) > > >

Re: [PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-19 Thread Marek Marczykowski-Górecki
On Thu, Aug 19, 2021 at 05:57:21PM +0200, Jan Beulich wrote: > On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > > *uart) > > } > > } > > > > +static void enable_exar_enhanced_bits(struct ns16550 *uart) >

Re: [PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-19 Thread Jan Beulich
On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > *uart) > } > } > > +static void enable_exar_enhanced_bits(struct ns16550 *uart) Afaics the parameter can be pointer-to-const. > +{ > +#ifdef NS16550_PCI > +

[PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-18 Thread Marek Marczykowski-Górecki
Besides standard UART setup, this device needs enabling (vendor-specific) "Enhanced Control Bits" - otherwise disabling hardware control flow (MCR[2]) is ignored. Add appropriate quirk to the ns16550_setup_preirq(), similar to the handle_dw_usr_busy_quirk(). The new function act on Exar 2-, 4-, and