Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-07 Thread Jan Beulich
On 06.01.2025 21:03, Denis Mukhin wrote: > > On Monday, January 6th, 2025 at 1:58 AM, Jan Beulich > wrote: > >> >> >> On 04.01.2025 04:30, Denis Mukhin wrote: >> >>> On Thursday, December 12th, 2024 at 2:12 AM, Roger Pau Monné >>> roger@citrix.com wrote: >>> On Thu, Dec 05, 2024 at 08

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-06 Thread Denis Mukhin
On Monday, January 6th, 2025 at 1:58 AM, Jan Beulich wrote: > > > On 04.01.2025 04:30, Denis Mukhin wrote: > > > On Thursday, December 12th, 2024 at 2:12 AM, Roger Pau Monné > > roger@citrix.com wrote: > > > > > On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote:

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-06 Thread Jan Beulich
On 04.01.2025 04:30, Denis Mukhin wrote: > On Thursday, December 12th, 2024 at 2:12 AM, Roger Pau Monné > wrote: >> On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote: >>> --- a/xen/drivers/char/console.c >>> +++ b/xen/drivers/char/console.c >>> @@ -463,82 +463,100 @@ stati

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-06 Thread Jan Beulich
On 04.01.2025 04:07, Denis Mukhin wrote: > On Tuesday, December 10th, 2024 at 7:02 AM, Jan Beulich > wrote: >> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: >>> +int console_set_owner(domid_t domid) >> >> >> static? Iirc Misra doesn't like non-static functions which aren't called >> from

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-03 Thread Denis Mukhin
On Thursday, December 12th, 2024 at 2:12 AM, Roger Pau Monné wrote: > > > On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote: > > > From: Denis Mukhin dmuk...@ford.com > > > > console_set_owner() is introduced for setting the new console owner. > > > > Switches console own

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-03 Thread Denis Mukhin
On Thursday, December 12th, 2024 at 3:59 AM, Jan Beulich wrote: > > > On 12.12.2024 11:12, Roger Pau Monné wrote: > > > On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote: > > > > > +static struct domain *rcu_lock_domain_console_by_id(domid_t domid) > > > +{ > > > + struct

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2025-01-03 Thread Denis Mukhin
On Tuesday, December 10th, 2024 at 7:02 AM, Jan Beulich wrote: > > > On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > > > --- a/xen/drivers/char/console.c > > +++ b/xen/drivers/char/console.c > > @@ -463,82 +463,100 @@ static void cf_check dump_console_ring_key(unsigned > > char key) > >

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2024-12-12 Thread Roger Pau Monné
On Thu, Dec 12, 2024 at 12:59:30PM +0100, Jan Beulich wrote: > On 12.12.2024 11:12, Roger Pau Monné wrote: > > On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote: > >> +static struct domain *rcu_lock_domain_console_by_id(domid_t domid) > >> +{ > >> +struct domain *d; > >>

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2024-12-12 Thread Jan Beulich
On 12.12.2024 11:12, Roger Pau Monné wrote: > On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote: >> +static struct domain *rcu_lock_domain_console_by_id(domid_t domid) >> +{ >> +struct domain *d; >> + >> +d = rcu_lock_domain_by_id(domid); >> + > > Nit: I would remov

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2024-12-12 Thread Roger Pau Monné
On Thu, Dec 05, 2024 at 08:41:49PM -0800, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > console_set_owner() is introduced for setting the new console owner. > > Switches console owner to domain ID vs range of integer numbers mapped to > domain IDs. > > This a public API to console d

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -463,82 +463,100 @@ static void cf_check dump_console_ring_key(unsigned > char key) > > /* > * CTRL- changes input direction, rotating among Xen, Dom0, > - * and th

[PATCH v2 19/35] xen/console: introduce console_set_owner()

2024-12-05 Thread Denis Mukhin via B4 Relay
From: Denis Mukhin console_set_owner() is introduced for setting the new console owner. Switches console owner to domain ID vs range of integer numbers mapped to domain IDs. This a public API to console driver, will be used in the follow on code change. Signed-off-by: Denis Mukhin --- xen/dr