Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-04 Thread Jan Beulich
On 04.12.2020 12:08, Jürgen Groß wrote: > On 04.12.20 10:10, Jan Beulich wrote: >> On 01.12.2020 09:21, Juergen Gross wrote: >>> +static struct hypfs_funcs cpupool_dir_funcs = { >> >> Yet another missing const? > > Already fixed. > >> >>> +.enter = cpupool_dir_enter, >>> +.exit = cpupool_

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-04 Thread Jürgen Groß
On 04.12.20 10:10, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: @@ -1003,12 +1006,131 @@ static struct notifier_block cpu_nfb = { .notifier_call = cpu_callback }; +#ifdef CONFIG_HYPFS +static const struct hypfs_entry *cpupool_pooldir_enter( +const struct hypfs_ent

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-04 Thread Jan Beulich
On 01.12.2020 09:21, Juergen Gross wrote: > @@ -1003,12 +1006,131 @@ static struct notifier_block cpu_nfb = { > .notifier_call = cpu_callback > }; > > +#ifdef CONFIG_HYPFS > +static const struct hypfs_entry *cpupool_pooldir_enter( > +const struct hypfs_entry *entry); > + > +static struc

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-03 Thread Jürgen Groß
On 03.12.20 15:46, Jan Beulich wrote: On 02.12.2020 16:46, Jürgen Groß wrote: On 01.12.20 09:21, Juergen Gross wrote: @@ -1003,12 +1006,131 @@ static struct notifier_block cpu_nfb = { .notifier_call = cpu_callback }; +#ifdef CONFIG_HYPFS +static const struct hypfs_entry *cpupool_

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-03 Thread Jan Beulich
On 02.12.2020 16:46, Jürgen Groß wrote: > On 01.12.20 09:21, Juergen Gross wrote: >> @@ -1003,12 +1006,131 @@ static struct notifier_block cpu_nfb = { >> .notifier_call = cpu_callback >> }; >> >> +#ifdef CONFIG_HYPFS >> +static const struct hypfs_entry *cpupool_pooldir_enter( >> +con

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-02 Thread Jürgen Groß
On 01.12.20 09:21, Juergen Gross wrote: Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) - call hypfs_add_dir() in helper (Dario Faggioli) - switch loc

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-01 Thread Jürgen Groß
On 01.12.20 10:00, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) Any particular reas

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-01 Thread Jan Beulich
On 01.12.2020 09:21, Juergen Gross wrote: > Add /cpupool/ directories to hypfs. Those are completely > dynamic, so the related hypfs access functions need to be implemented. > > Signed-off-by: Juergen Gross > --- > V2: > - added const (Jan Beulich) Any particular reason this doesn't extend to ..

[PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-01 Thread Juergen Gross
Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) - call hypfs_add_dir() in helper (Dario Faggioli) - switch locking to enter/exit callbacks --- docs/mis